Skip to content

Commit b13b9dd

Browse files
github-actions[bot]web-flowantonis
authored
chore(deps): update Cocoa SDK to v8.53.2 (#4986)
* chore: update scripts/update-cocoa.sh to 8.53.2 * fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump (#4988) * chore: update scripts/update-cocoa.sh to 8.53.2 * fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump * Remove duplicate changelog entry after merge --------- Co-authored-by: GitHub <[email protected]> --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Antonis Lilis <[email protected]>
1 parent ffab994 commit b13b9dd

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
- Bump JavaScript SDK from v8.54.0 to v8.55.0 ([#4981](https://github.com/getsentry/sentry-react-native/pull/4981))
1414
- [changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md#8550)
1515
- [diff](https://github.com/getsentry/sentry-javascript/compare/8.54.0...8.55.0)
16+
- Bump Cocoa SDK from v8.53.1 to v8.53.2 ([#4986](https://github.com/getsentry/sentry-react-native/pull/4986))
17+
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8532)
18+
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.53.1...8.53.2)
1619

1720
## 6.17.0
1821

packages/core/RNSentry.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Pod::Spec.new do |s|
4444

4545
s.compiler_flags = other_cflags
4646

47-
s.dependency 'Sentry/HybridSDK', '8.53.1'
47+
s.dependency 'Sentry/HybridSDK', '8.53.2'
4848

4949
if defined? install_modules_dependencies
5050
# Default React Native dependencies for 0.71 and above (new and legacy architecture)

packages/core/ios/RNSentryReplayBreadcrumbConverter.m

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,23 @@ - (instancetype _Nonnull)init
5050
SentryRRWebEvent *nativeBreadcrumb = [self->defaultConverter convertFrom:breadcrumb];
5151

5252
// ignore native navigation breadcrumbs
53-
if (nativeBreadcrumb && nativeBreadcrumb.data && nativeBreadcrumb.data[@"payload"]
54-
&& nativeBreadcrumb.data[@"payload"][@"category"] &&
55-
[nativeBreadcrumb.data[@"payload"][@"category"] isEqualToString:@"navigation"]) {
56-
return nil;
53+
if (nativeBreadcrumb) {
54+
@try {
55+
id data = [nativeBreadcrumb valueForKey:@"data"];
56+
if (data && [data isKindOfClass:[NSDictionary class]]) {
57+
NSDictionary *dataDict = (NSDictionary *)data;
58+
id payload = dataDict[@"payload"];
59+
if (payload && [payload isKindOfClass:[NSDictionary class]]) {
60+
NSDictionary *payloadDict = (NSDictionary *)payload;
61+
NSString *category = payloadDict[@"category"];
62+
if ([category isEqualToString:@"navigation"]) {
63+
return nil;
64+
}
65+
}
66+
}
67+
} @catch (NSException *exception) {
68+
// Just continue without ignoring native navigation breadcrumbs
69+
}
5770
}
5871

5972
return nativeBreadcrumb;

0 commit comments

Comments
 (0)