Skip to content

Investigate improving test_transport_works #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linear bot opened this issue Apr 14, 2025 · 1 comment
Open

Investigate improving test_transport_works #4287

linear bot opened this issue Apr 14, 2025 · 1 comment
Labels

Comments

@linear
Copy link

linear bot commented Apr 14, 2025

[opened by @szokeasaurusrex]

There are multiple problems with this test:

  • The test is flaky (specifically on Python 3.10)
    • The flakes appear related to asserting that stdout and stderr is empty
  • The test appears to be checking multiple things. It is unclear which of these is important
    • e.g. maybe we should not assert anything about stdout and stderr
  • The test is generally difficult to understand
  • The test takes a very long time to run because it is parameterized with many different combinations and all the tests are forked
    • Maybe we can reduce the combinations we check and stop forking the test
@stephanie-anderson stephanie-anderson added the Python SDK label Apr 25, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant