Skip to content

Commit 415e9e7

Browse files
committed
test(celery): add traceparent header assertions in task header tests
1 parent dd0e45a commit 415e9e7

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

tests/integrations/celery/test_celery.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,7 @@ def dummy_task(self, x, y):
496496
expected_headers = sentry_crons_setup.copy()
497497
# Newly added headers
498498
expected_headers["sentry-trace"] = mock.ANY
499+
expected_headers["traceparent"] = mock.ANY
499500
expected_headers["baggage"] = mock.ANY
500501
expected_headers["sentry-task-enqueued-time"] = mock.ANY
501502

@@ -569,6 +570,7 @@ def test_apply_async_manually_span(sentry_init):
569570
def dummy_function(*args, **kwargs):
570571
headers = kwargs.get("headers")
571572
assert "sentry-trace" in headers
573+
assert "traceparent" in headers
572574
assert "baggage" in headers
573575

574576
wrapped = _wrap_task_run(dummy_function)
@@ -813,18 +815,23 @@ def test_send_task_wrapped(
813815
assert set(kwargs["headers"].keys()) == {
814816
"sentry-task-enqueued-time",
815817
"sentry-trace",
818+
"traceparent",
816819
"baggage",
817820
"headers",
818821
}
819822
assert set(kwargs["headers"]["headers"].keys()) == {
820823
"sentry-trace",
824+
"traceparent",
821825
"baggage",
822826
"sentry-task-enqueued-time",
823827
}
824828
assert (
825829
kwargs["headers"]["sentry-trace"]
826830
== kwargs["headers"]["headers"]["sentry-trace"]
827831
)
832+
assert (
833+
kwargs["headers"]["traceparent"] == kwargs["headers"]["headers"]["traceparent"]
834+
)
828835

829836
(event,) = events # We should have exactly one event (the transaction)
830837
assert event["type"] == "transaction"

tests/integrations/celery/test_update_celery_task_headers.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ def test_span_with_transaction(sentry_init):
8383

8484
assert outgoing_headers["sentry-trace"] == span.to_traceparent()
8585
assert outgoing_headers["headers"]["sentry-trace"] == span.to_traceparent()
86+
assert outgoing_headers["traceparent"] == span.to_w3c_traceparent()
87+
assert (
88+
outgoing_headers["headers"]["traceparent"] == span.to_w3c_traceparent()
89+
)
8690
assert outgoing_headers["baggage"] == transaction.get_baggage().serialize()
8791
assert (
8892
outgoing_headers["headers"]["baggage"]
@@ -103,6 +107,10 @@ def test_span_with_transaction_custom_headers(sentry_init):
103107

104108
assert outgoing_headers["sentry-trace"] == span.to_traceparent()
105109
assert outgoing_headers["headers"]["sentry-trace"] == span.to_traceparent()
110+
assert outgoing_headers["traceparent"] == span.to_w3c_traceparent()
111+
assert (
112+
outgoing_headers["headers"]["traceparent"] == span.to_w3c_traceparent()
113+
)
106114

107115
incoming_baggage = Baggage.from_incoming_header(headers["baggage"])
108116
combined_baggage = copy(transaction.get_baggage())
@@ -145,6 +153,8 @@ def test_celery_trace_propagation_default(sentry_init, monitor_beat_tasks):
145153

146154
assert outgoing_headers["sentry-trace"] == scope.get_traceparent()
147155
assert outgoing_headers["headers"]["sentry-trace"] == scope.get_traceparent()
156+
assert outgoing_headers["traceparent"] == scope._get_w3c_traceparent()
157+
assert outgoing_headers["headers"]["traceparent"] == scope._get_w3c_traceparent()
148158
assert outgoing_headers["baggage"] == scope.get_baggage().serialize()
149159
assert outgoing_headers["headers"]["baggage"] == scope.get_baggage().serialize()
150160

@@ -181,6 +191,8 @@ def test_celery_trace_propagation_traces_sample_rate(
181191

182192
assert outgoing_headers["sentry-trace"] == scope.get_traceparent()
183193
assert outgoing_headers["headers"]["sentry-trace"] == scope.get_traceparent()
194+
assert outgoing_headers["traceparent"] == scope._get_w3c_traceparent()
195+
assert outgoing_headers["headers"]["traceparent"] == scope._get_w3c_traceparent()
184196
assert outgoing_headers["baggage"] == scope.get_baggage().serialize()
185197
assert outgoing_headers["headers"]["baggage"] == scope.get_baggage().serialize()
186198

@@ -217,6 +229,8 @@ def test_celery_trace_propagation_enable_tracing(
217229

218230
assert outgoing_headers["sentry-trace"] == scope.get_traceparent()
219231
assert outgoing_headers["headers"]["sentry-trace"] == scope.get_traceparent()
232+
assert outgoing_headers["traceparent"] == scope._get_w3c_traceparent()
233+
assert outgoing_headers["headers"]["traceparent"] == scope._get_w3c_traceparent()
220234
assert outgoing_headers["baggage"] == scope.get_baggage().serialize()
221235
assert outgoing_headers["headers"]["baggage"] == scope.get_baggage().serialize()
222236

0 commit comments

Comments
 (0)