Skip to content

Commit 2a1dafb

Browse files
committed
scope fix, notes update
1 parent b7e508e commit 2a1dafb

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

sentry_sdk/scope.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1232,8 +1232,7 @@ def start_streamed_span(
12321232
# TODO: rename to start_span once we drop the old API
12331233
if parent_span is None:
12341234
# Get currently active span
1235-
# TODO[span-first]: should this be current scope?
1236-
parent_span = self.span or self.get_isolation_scope().span # type: ignore
1235+
parent_span = self.span or self.get_current_scope().span # type: ignore
12371236

12381237
# If no specific parent_span provided and there is no currently
12391238
# active span, this is a segment

sentry_sdk/traces.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,22 +86,14 @@ def __str__(self) -> str:
8686

8787
"""
8888
TODO[span-first] / notes
89-
- redis, http, subprocess breadcrumbs (maybe_create_breadcrumbs_from_span) work
90-
on op, change or ignore?
9189
- tags
92-
- initial status: OK? or unset? -> OK
9390
- dropped spans are not migrated
9491
- recheck transaction.finish <-> Streamedspan.end
9592
- profiling: drop transaction based
9693
- profiling: actually send profiles
9794
- maybe: use getters/setter OR properties but not both
9895
- add size-based flushing to buffer(s)
9996
- migrate transaction sample_rand logic
100-
- custom_sampling_context?
101-
- store on scope/propagation context instead?
102-
- function to set on propagation context
103-
- noop spans
104-
- iso
10597
- check where we're auto filtering out spans in integrations (health checks etc?)
10698
10799
Notes:

0 commit comments

Comments
 (0)