fix(react-router): Ensure source map upload fails silently if Sentry CLI fails #17081
+65
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
Lms24
requested review from
a team,
stephanie-anderson,
chargome and
msonnb
and removed request for
a team and
stephanie-anderson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry CLI's
cli.releases.uploadSourceMapsmethod previously never rejected when the actual CLI binary execution exited with an error code. In CLI 2.49.0 and 2.50.0 I added a new execution mode variant (rejectOnError) which continues to pipe stdio to the process (the RR SDKs' upload script) but now also rejects on error.This PR bumps Sentry CLI and configures it to actually reject now. We already catch the rejection and fail silently. Nothing changed here.