Skip to content

Commit cf2ddee

Browse files
ilya-pirogovbenvinegar
authored andcommitted
Add return type for showReportDialog (#711)
1 parent 3e0877a commit cf2ddee

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"scripts": {
77
"pretest": "npm install",
88
"test": "grunt test && npm run-script test-typescript",
9-
"test-typescript": "node_modules/typescript/bin/tsc --noEmit typescript/raven-tests.ts"
9+
"test-typescript": "node_modules/typescript/bin/tsc --noEmit --noImplicitAny typescript/raven-tests.ts"
1010
},
1111
"repository": {
1212
"type": "git",

typescript/raven-tests.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ Raven.captureBreadcrumb({});
5959
Raven.setRelease('abc123');
6060
Raven.setEnvironment('production');
6161

62-
Raven.setDataCallback(function (data) {});
63-
Raven.setDataCallback(function (data, original) {});
64-
Raven.setShouldSendCallback(function (data) {});
65-
Raven.setShouldSendCallback(function (data, original) {});
62+
Raven.setDataCallback(function (data: any) {});
63+
Raven.setDataCallback(function (data: any, original: any) {});
64+
Raven.setShouldSendCallback(function (data: any) {});
65+
Raven.setShouldSendCallback(function (data: any, original: any) {});
6666

6767
Raven.showReportDialog({
6868
eventId: 'abcdef123456'

typescript/raven.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ interface RavenStatic {
211211
setShouldSendCallback(data: any, orig?: any): RavenStatic;
212212

213213
/** Show Sentry user feedback dialog */
214-
showReportDialog(options: Object);
214+
showReportDialog(options: Object): void;
215215
}
216216

217217
interface RavenTransportOptions {

0 commit comments

Comments
 (0)