3.2.0 (#641)

benvinegar · web-flow · commit aeac6ce91e56 · 2016-07-05T15:50:36.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## 3.2.0
+* CHANGE: Callbacks set via `setDataCallback`, `setShouldSendCallback` now receive any prior-set callback as the 2nd argument. See: https://github.com/getsentry/raven-js/pull/636
+* CHANGE: Raven.js no longer passes a 'message' interface for exceptions. See: https://github.com/getsentry/raven-js/pull/632
+* CHANGE: Log level now recorded for "sentry" breadcrumbs. See: https://github.com/getsentry/raven-js/pull/633
+
 ## 3.1.1
 * BUGFIX: Fix message truncation occurring before dataCallback is invoked. See: https://github.com/getsentry/raven-js/issues/605
 * BUGFIX: Fix pushState error in Chrome Apps. See: https://github.com/getsentry/raven-js/issues/601
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "raven-js",
-  "version": "3.1.1",
+  "version": "3.2.0",
   "dependencies": {},
   "main": "dist/raven.js",
   "ignore": [
diff --git a/dist/plugins/angular.js b/dist/plugins/angular.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
+/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit
diff --git a/dist/plugins/angular.min.js b/dist/plugins/angular.min.js
diff --git a/dist/plugins/console.js b/dist/plugins/console.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
+/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit
diff --git a/dist/plugins/console.min.js b/dist/plugins/console.min.js
diff --git a/dist/plugins/ember.js b/dist/plugins/ember.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
+/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit
diff --git a/dist/plugins/ember.min.js b/dist/plugins/ember.min.js
diff --git a/dist/plugins/require.js b/dist/plugins/require.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
+/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit
diff --git a/dist/plugins/require.min.js b/dist/plugins/require.min.js
diff --git a/dist/raven.js b/dist/raven.js
@@ -1,4 +1,4 @@
-/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
+/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */
 
 /*
  * Includes TraceKit
@@ -150,7 +150,7 @@ Raven.prototype = {
     // webpack (using a build step causes webpack #1617). Grunt verifies that
     // this value matches package.json during build.
     //   See: https://github.com/getsentry/raven-js/issues/465
-    VERSION: '3.1.1',
+    VERSION: '3.2.0',
 
     debug: false,
 
@@ -515,7 +515,10 @@ Raven.prototype = {
      * @return {Raven}
      */
     setDataCallback: function(callback) {
-        this._globalOptions.dataCallback = callback;
+        var original = this._globalOptions.dataCallback;
+        this._globalOptions.dataCallback = isFunction(callback)
+          ? function (data) { return callback(data, original); }
+          : callback;
 
         return this;
     },
@@ -528,7 +531,10 @@ Raven.prototype = {
      * @return {Raven}
      */
     setShouldSendCallback: function(callback) {
-        this._globalOptions.shouldSendCallback = callback;
+        var original = this._globalOptions.shouldSendCallback;
+        this._globalOptions.shouldSendCallback = isFunction(callback)
+            ? function (data) { return callback(data, original); }
+            : callback;
 
         return this;
     },
@@ -1126,12 +1132,11 @@ Raven.prototype = {
     },
 
     _processException: function(type, message, fileurl, lineno, frames, options) {
-        var stacktrace, fullMessage;
+        var stacktrace;
 
         if (!!this._globalOptions.ignoreErrors.test && this._globalOptions.ignoreErrors.test(message)) return;
 
         message += '';
-        fullMessage = (type ? type + ': ' : '') + message;
 
         if (frames && frames.length) {
             fileurl = frames[0].filename || fileurl;
@@ -1161,8 +1166,7 @@ Raven.prototype = {
                     stacktrace: stacktrace
                 }]
             },
-            culprit: fileurl,
-            message: fullMessage
+            culprit: fileurl
         }, options);
 
         // Fire away!
@@ -1284,10 +1288,14 @@ Raven.prototype = {
             auth.sentry_secret = this._globalSecret;
         }
 
+        var exception = data.exception && data.exception.values[0];
         this.captureBreadcrumb({
             category: 'sentry',
-            message: data.message,
-            event_id: data.event_id
+            message: exception
+                ? (exception.type ? exception.type + ': ' : '') + exception.message
+                : data.message,
+            event_id: data.event_id,
+            level: data.level || 'error' // presume error unless specified
         });
 
         var url = this._globalEndpoint;
@@ -1355,13 +1363,6 @@ Raven.prototype = {
         request.send(JSON.stringify(opts.data));
     },
 
-    // Note: this is shitty, but I can't figure out how to get
-    // sinon to stub document.createElement without breaking everything
-    // so this wrapper is just so I can stub it for tests.
-    _newImage: function() {
-        return document.createElement('img');
-    },
-
     _logDebug: function(level) {
         if (this._originalConsoleMethods[level] && this.debug) {
             // In IE<10 console methods do not have their own 'apply' method
diff --git a/dist/raven.min.js b/dist/raven.min.js
diff --git a/dist/raven.min.js.map b/dist/raven.min.js.map
diff --git a/dist/sri.json b/dist/sri.json
@@ -1,20 +1,20 @@
 {
   "@dist/raven.js": {
     "hashes": {
-      "sha256": "YfJL5HnkAUb6LaT41WdeubM9tHcj1KLNZzv091O0kAA=",
-      "sha512": "rc2JMbKhV8x5vp/NPhCGMsrepxYezWg/Xyvb0saXLKNy8vC5unYVfMXxe6KS9WVhCPOIt12OoZDKDmohxpT60Q=="
+      "sha256": "l424R9SHtp9TbZqeaYBEAqbTK4GypSj13iR6w3Er1nE=",
+      "sha512": "jPVWiZXfhkVsdmExC8WQjD+sBgeipsaxylooysTGsMCtegPXqOqnh/8kstLhyh8suvIHX5FM1LRHZdgANvtfYQ=="
     },
     "type": null,
-    "integrity": "sha256-YfJL5HnkAUb6LaT41WdeubM9tHcj1KLNZzv091O0kAA= sha512-rc2JMbKhV8x5vp/NPhCGMsrepxYezWg/Xyvb0saXLKNy8vC5unYVfMXxe6KS9WVhCPOIt12OoZDKDmohxpT60Q==",
+    "integrity": "sha256-l424R9SHtp9TbZqeaYBEAqbTK4GypSj13iR6w3Er1nE= sha512-jPVWiZXfhkVsdmExC8WQjD+sBgeipsaxylooysTGsMCtegPXqOqnh/8kstLhyh8suvIHX5FM1LRHZdgANvtfYQ==",
     "path": "dist/raven.js"
   },
   "@dist/raven.min.js": {
     "hashes": {
-      "sha256": "kgc2mY6SdVCVixqDm9Jx5zGX+JAIYPWpXY6QJAzLmhE=",
-      "sha512": "0Idcd2pOWVAvkBPiODuHMMq8YxGsrAc2SsFvQEdpQ2QGrPf/9OE2dUlspBBGC5UvD4Y/rbpY74SCVIfQzBBv8g=="
+      "sha256": "wFrEe9hRl6lKZoUmCxgr0R1BbDylMR+wd40N7o5uEJM=",
+      "sha512": "TxMxb9gCA8dX5xDcgClofPznLatqqf/9KdZ7P+0TZUetJSl/4GdvPZ5zI0AndeQOqf5IXCOUpNGznb/AAyNcJA=="
     },
     "type": null,
-    "integrity": "sha256-kgc2mY6SdVCVixqDm9Jx5zGX+JAIYPWpXY6QJAzLmhE= sha512-0Idcd2pOWVAvkBPiODuHMMq8YxGsrAc2SsFvQEdpQ2QGrPf/9OE2dUlspBBGC5UvD4Y/rbpY74SCVIfQzBBv8g==",
+    "integrity": "sha256-wFrEe9hRl6lKZoUmCxgr0R1BbDylMR+wd40N7o5uEJM= sha512-TxMxb9gCA8dX5xDcgClofPznLatqqf/9KdZ7P+0TZUetJSl/4GdvPZ5zI0AndeQOqf5IXCOUpNGznb/AAyNcJA==",
     "path": "dist/raven.min.js"
   }
 }
diff --git a/docs/config.rst b/docs/config.rst
@@ -237,7 +237,7 @@ Putting it all together
     <body>
         ...
         <script src="jquery.min.js"></script>
-        <script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
+        <script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
         <script>
             Raven.config('___PUBLIC_DSN___', {
                 logger: 'my-logger',
diff --git a/docs/index.rst b/docs/index.rst
@@ -26,7 +26,7 @@ scripts.  For all details see :doc:`install`.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
 
 
 Configuring the Client
diff --git a/docs/install.rst b/docs/install.rst
@@ -9,7 +9,7 @@ So for example:
 .. sourcecode:: html
 
     <script src="jquery.js"></script>
-    <script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
     <script>Raven.config('___PUBLIC_DSN___').install();</script>
     <script src="app.js"></script>
 
@@ -28,7 +28,7 @@ Our CDN distributes builds with and without :doc:`integrations <integrations/ind
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
 
 This version does not include any plugins. See `ravenjs.com
 <http://ravenjs.com/>`_ for more information about plugins and getting
diff --git a/docs/integrations/angular.rst b/docs/integrations/angular.rst
@@ -24,7 +24,7 @@ Example:
 .. sourcecode:: html
 
     <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>
-    <script src="https://cdn.ravenjs.com/3.1.1/angular/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/angular/raven.min.js"></script>
     <script>Raven.config('___PUBLIC_DSN___').install();</script>
 
 Note that this CDN build auto-initializes the Angular plugin.
diff --git a/docs/integrations/backbone.rst b/docs/integrations/backbone.rst
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
 
 Configuring the Client
 ----------------------
diff --git a/docs/integrations/ember.rst b/docs/integrations/ember.rst
@@ -23,7 +23,7 @@ Example:
 .. sourcecode:: html
 
     <script src="http://builds.emberjs.com/tags/v2.3.1/ember.prod.js"></script>
-    <script src="https://cdn.ravenjs.com/3.1.1/ember/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/ember/raven.min.js"></script>
     <script>Raven.config('___PUBLIC_DSN___').install();</script>
 
 Note that this CDN build auto-initializes the Ember plugin.
diff --git a/docs/integrations/react.rst b/docs/integrations/react.rst
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
 
 Configuring the Client
 ----------------------
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "raven-js",
-  "version": "3.1.1",
+  "version": "3.2.0",
   "license": "BSD-2-Clause",
   "homepage": "https://getsentry.com",
   "scripts": {
diff --git a/src/raven.js b/src/raven.js
@@ -86,7 +86,7 @@ Raven.prototype = {
     // webpack (using a build step causes webpack #1617). Grunt verifies that
     // this value matches package.json during build.
     //   See: https://github.com/getsentry/raven-js/issues/465
-    VERSION: '3.1.1',
+    VERSION: '3.2.0',
 
     debug: false,
 
diff --git a/test/raven.test.js b/test/raven.test.js
@@ -959,7 +959,7 @@ describe('globals', function() {
                 extra: {'session:duration': 100},
             });
             assert.deepEqual(opts.auth, {
-                sentry_client: 'raven-js/3.1.1',
+                sentry_client: 'raven-js/3.2.0',
                 sentry_key: 'abc',
                 sentry_version: '7'
             });
@@ -1006,7 +1006,7 @@ describe('globals', function() {
                 extra: {'session:duration': 100},
             });
             assert.deepEqual(opts.auth, {
-                sentry_client: 'raven-js/3.1.1',
+                sentry_client: 'raven-js/3.2.0',
                 sentry_key: 'abc',
                 sentry_secret: 'def',
                 sentry_version: '7'

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "raven-js",`
`3`		`- "version": "3.1.1",`
	`3`	`+ "version": "3.2.0",`
`4`	`4`	`"dependencies": {},`
`5`	`5`	`"main": "dist/raven.js",`
`6`	`6`	`"ignore": [`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/! Raven.js 3.1.1 (34f456e) \| github.com/getsentry/raven-js /`
	`1`	`+/! Raven.js 3.2.0 (d052e7e) \| github.com/getsentry/raven-js /`
`2`	`2`
`3`	`3`	`/*`
`4`	`4`	`* Includes TraceKit`