Skip to content

Commit 5601a14

Browse files
committed
fix: Broken travis tests on master, Fix node tests
1 parent 867c8b6 commit 5601a14

File tree

3 files changed

+23
-19
lines changed

3 files changed

+23
-19
lines changed

.travis/before_script.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
#!/bin/bash
22
set -e
33

4+
if [[ $TRAVIS_BRANCH == 'master' ]]; then
5+
CHANGES="[force ci]"
6+
else
47
CHANGES=$(git --no-pager diff --name-only FETCH_HEAD $(git merge-base FETCH_HEAD master))
8+
fi
59

610
if [ -n "$(grep 'raven-js' <<< "$CHANGES")" ]; then
711
RAVEN_JS_CHANGES=true

packages/hub/src/hub.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class Hub {
3838
* Internal helper function to call a method on the top client if it exists.
3939
*
4040
* @param method The method to call on the client/client.
41-
* @param args Arguments to pass to the client/fontend.
41+
* @param args Arguments to pass to the client/frontend.
4242
*/
4343
private invokeClient(method: string, ...args: any[]): void {
4444
const top = this.getStackTop();
@@ -52,7 +52,7 @@ export class Hub {
5252
* exists.
5353
*
5454
* @param method The method to call on the client/client.
55-
* @param args Arguments to pass to the client/fontend.
55+
* @param args Arguments to pass to the client/frontend.
5656
*/
5757
private invokeClientAsync(method: string, ...args: any[]): void {
5858
const top = this.getStackTop();

packages/node/test/index.test.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ describe('SentryNode', () => {
118118
});
119119

120120
test('capture an exception', done => {
121+
expect.assertions(6);
121122
getDefaultHub().pushScope();
122123
getDefaultHub().bindClient(
123124
new NodeClient({
@@ -145,6 +146,7 @@ describe('SentryNode', () => {
145146
});
146147

147148
test('capture a message', done => {
149+
expect.assertions(2);
148150
getDefaultHub().pushScope();
149151
getDefaultHub().bindClient(
150152
new NodeClient({
@@ -161,6 +163,7 @@ describe('SentryNode', () => {
161163
});
162164

163165
test('capture an event', done => {
166+
expect.assertions(2);
164167
getDefaultHub().pushScope();
165168
getDefaultHub().bindClient(
166169
new NodeClient({
@@ -176,26 +179,23 @@ describe('SentryNode', () => {
176179
getDefaultHub().popScope();
177180
});
178181

179-
test('capture an event in a domain', async () => {
182+
test('capture an event in a domain', async () =>
180183
new Promise<void>(resolve => {
181184
const d = domain.create();
185+
const client = new NodeClient({
186+
afterSend: (event: SentryEvent) => {
187+
expect(event.message).toBe('test');
188+
expect(event.exception).toBeUndefined();
189+
resolve();
190+
d.exit();
191+
},
192+
dsn,
193+
});
182194
d.run(() => {
183-
getDefaultHub().pushScope();
184-
getDefaultHub().bindClient(
185-
new NodeClient({
186-
afterSend: (event: SentryEvent) => {
187-
expect(event.message).toBe('test');
188-
expect(event.exception).toBeUndefined();
189-
resolve();
190-
d.exit();
191-
},
192-
dsn,
193-
}),
194-
);
195-
captureEvent({ message: 'test' });
196-
getDefaultHub().popScope();
195+
getDefaultHub().bindClient(client);
196+
expect(getDefaultHub().getClient()).toBe(client);
197+
getDefaultHub().captureEvent({ message: 'test' });
197198
});
198-
});
199-
});
199+
}));
200200
});
201201
});

0 commit comments

Comments
 (0)