build: Add @typescript-eslint/consistent-type-imports rule (#6662)

This ensures we use a `type` import when we only need type stuff.

Author: mydea

packages/angular/src/errorhandler.ts

@@ -1,5 +1,6 @@
 import { HttpErrorResponse } from '@angular/common/http';
-import { ErrorHandler as AngularErrorHandler, Inject, Injectable } from '@angular/core';
+import type { ErrorHandler as AngularErrorHandler } from '@angular/core';
+import { Inject, Injectable } from '@angular/core';
 import * as Sentry from '@sentry/browser';
 import { captureException } from '@sentry/browser';
 import { addExceptionMechanism, isString } from '@sentry/utils';

packages/angular/src/sdk.ts

@@ -1,5 +1,6 @@
 import { VERSION } from '@angular/core';
-import { BrowserOptions, init as browserInit, SDK_VERSION, setContext } from '@sentry/browser';
+import type { BrowserOptions } from '@sentry/browser';
+import { init as browserInit, SDK_VERSION, setContext } from '@sentry/browser';
 import { logger } from '@sentry/utils';
 
 import { ANGULAR_MINIMUM_VERSION } from './constants';

packages/angular/src/tracing.ts

@@ -1,10 +1,13 @@
 /* eslint-disable max-lines */
-import { AfterViewInit, Directive, Injectable, Input, NgModule, OnDestroy, OnInit } from '@angular/core';
-import { ActivatedRouteSnapshot, Event, NavigationEnd, NavigationStart, ResolveEnd, Router } from '@angular/router';
+import type { AfterViewInit, OnDestroy, OnInit } from '@angular/core';
+import { Directive, Injectable, Input, NgModule } from '@angular/core';
+import type { ActivatedRouteSnapshot, Event, Router } from '@angular/router';
+import { NavigationEnd, NavigationStart, ResolveEnd } from '@angular/router';
 import { getCurrentHub, WINDOW } from '@sentry/browser';
-import { Span, Transaction, TransactionContext } from '@sentry/types';
+import type { Span, Transaction, TransactionContext } from '@sentry/types';
 import { logger, stripUrlQueryAndFragment, timestampWithMs } from '@sentry/utils';
-import { Observable, Subscription } from 'rxjs';
+import type { Observable } from 'rxjs';
+import { Subscription } from 'rxjs';
 import { filter, tap } from 'rxjs/operators';
 
 import { ANGULAR_INIT_OP, ANGULAR_OP, ANGULAR_ROUTING_OP } from './constants';

packages/angular/test/tracing.test.ts

@@ -1,6 +1,6 @@
 import { Component } from '@angular/core';
-import { ActivatedRouteSnapshot } from '@angular/router';
-import { Hub } from '@sentry/types';
+import type { ActivatedRouteSnapshot } from '@angular/router';
+import type { Hub } from '@sentry/types';
 
 import { instrumentAngularRouting, TraceClassDecorator, TraceDirective, TraceMethodDecorator } from '../src';
 import { getParameterizedRouteFromSnapshot } from '../src/tracing';

packages/angular/test/utils/index.ts

@@ -1,8 +1,10 @@
 import { Component, NgModule } from '@angular/core';
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { Router, Routes } from '@angular/router';
+import type { ComponentFixture } from '@angular/core/testing';
+import { TestBed } from '@angular/core/testing';
+import type { Routes } from '@angular/router';
+import { Router } from '@angular/router';
 import { RouterTestingModule } from '@angular/router/testing';
-import { Transaction } from '@sentry/types';
+import type { Transaction } from '@sentry/types';
 
 import { instrumentAngularRouting, TraceService } from '../../src';
 

packages/browser/src/client.ts

@@ -1,13 +1,21 @@
-import { BaseClient, getEnvelopeEndpointWithUrlEncodedAuth, Scope, SDK_VERSION } from '@sentry/core';
-import type { BrowserClientReplayOptions } from '@sentry/types';
-import { ClientOptions, Event, EventHint, Options, Severity, SeverityLevel } from '@sentry/types';
+import type { Scope } from '@sentry/core';
+import { BaseClient, getEnvelopeEndpointWithUrlEncodedAuth, SDK_VERSION } from '@sentry/core';
+import type {
+  BrowserClientReplayOptions,
+  ClientOptions,
+  Event,
+  EventHint,
+  Options,
+  Severity,
+  SeverityLevel,
+} from '@sentry/types';
 import { createClientReportEnvelope, dsnToString, logger, serializeEnvelope } from '@sentry/utils';
 
 import { eventFromException, eventFromMessage } from './eventbuilder';
 import { WINDOW } from './helpers';
-import { Breadcrumbs } from './integrations';
+import type { Breadcrumbs } from './integrations';
 import { BREADCRUMB_INTEGRATION_ID } from './integrations/breadcrumbs';
-import { BrowserTransportOptions } from './transports/types';
+import type { BrowserTransportOptions } from './transports/types';
 /**
  * Configuration options for the Sentry Browser SDK.
  * @see @sentry/types Options for more information.

packages/browser/src/eventbuilder.ts

@@ -1,5 +1,5 @@
 import { getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Exception, Severity, SeverityLevel, StackFrame, StackParser } from '@sentry/types';
+import type { Event, EventHint, Exception, Severity, SeverityLevel, StackFrame, StackParser } from '@sentry/types';
 import {
   addExceptionMechanism,
   addExceptionTypeValue,

packages/browser/src/helpers.ts

@@ -1,5 +1,5 @@
 import { captureException, withScope } from '@sentry/core';
-import { DsnLike, Event as SentryEvent, Mechanism, Scope, WrappedFunction } from '@sentry/types';
+import type { DsnLike, Event as SentryEvent, Mechanism, Scope, WrappedFunction } from '@sentry/types';
 import {
   addExceptionMechanism,
   addExceptionTypeValue,

packages/browser/src/integrations/breadcrumbs.ts

@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable max-lines */
 import { getCurrentHub } from '@sentry/core';
-import { Event, Integration } from '@sentry/types';
+import type { Event, Integration } from '@sentry/types';
 import {
   addInstrumentationHandler,
   getEventDescription,

packages/browser/src/integrations/dedupe.ts

@@ -1,4 +1,4 @@
-import { Event, EventProcessor, Exception, Hub, Integration, StackFrame } from '@sentry/types';
+import type { Event, EventProcessor, Exception, Hub, Integration, StackFrame } from '@sentry/types';
 import { logger } from '@sentry/utils';
 
 /** Deduplication filter */

packages/browser/src/integrations/globalhandlers.ts

@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 import { getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Hub, Integration, Primitive, StackParser } from '@sentry/types';
+import type { Event, EventHint, Hub, Integration, Primitive, StackParser } from '@sentry/types';
 import {
   addExceptionMechanism,
   addInstrumentationHandler,
@@ -11,7 +11,7 @@ import {
   logger,
 } from '@sentry/utils';
 
-import { BrowserClient } from '../client';
+import type { BrowserClient } from '../client';
 import { eventFromUnknownInput } from '../eventbuilder';
 import { shouldIgnoreOnError } from '../helpers';
 

packages/browser/src/integrations/httpcontext.ts

@@ -1,5 +1,5 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
-import { Event, Integration } from '@sentry/types';
+import type { Event, Integration } from '@sentry/types';
 
 import { WINDOW } from '../helpers';
 

packages/browser/src/integrations/linkederrors.ts

@@ -1,8 +1,8 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Exception, ExtendedError, Integration, StackParser } from '@sentry/types';
+import type { Event, EventHint, Exception, ExtendedError, Integration, StackParser } from '@sentry/types';
 import { isInstanceOf } from '@sentry/utils';
 
-import { BrowserClient } from '../client';
+import type { BrowserClient } from '../client';
 import { exceptionFromError } from '../eventbuilder';
 
 const DEFAULT_KEY = 'cause';

packages/browser/src/integrations/trycatch.ts

@@ -1,4 +1,4 @@
-import { Integration, WrappedFunction } from '@sentry/types';
+import type { Integration, WrappedFunction } from '@sentry/types';
 import { fill, getFunctionName, getOriginalFunction } from '@sentry/utils';
 
 import { WINDOW, wrap } from '../helpers';

packages/browser/src/sdk.ts

@@ -1,8 +1,8 @@
+import type { Hub } from '@sentry/core';
 import {
   getCurrentHub,
   getIntegrationsToSetup,
   getReportDialogEndpoint,
-  Hub,
   initAndBind,
   Integrations as CoreIntegrations,
 } from '@sentry/core';
@@ -14,8 +14,10 @@ import {
   supportsFetch,
 } from '@sentry/utils';
 
-import { BrowserClient, BrowserClientOptions, BrowserOptions } from './client';
-import { ReportDialogOptions, WINDOW, wrap as internalWrap } from './helpers';
+import type { BrowserClientOptions, BrowserOptions } from './client';
+import { BrowserClient } from './client';
+import type { ReportDialogOptions } from './helpers';
+import { WINDOW, wrap as internalWrap } from './helpers';
 import { Breadcrumbs, Dedupe, GlobalHandlers, HttpContext, LinkedErrors, TryCatch } from './integrations';
 import { defaultStackParser } from './stack-parsers';
 import { makeFetchTransport, makeXHRTransport } from './transports';

packages/browser/src/stack-parsers.ts

@@ -1,4 +1,4 @@
-import { StackFrame, StackLineParser, StackLineParserFn } from '@sentry/types';
+import type { StackFrame, StackLineParser, StackLineParserFn } from '@sentry/types';
 import { createStackParser } from '@sentry/utils';
 
 // global reference to slice

packages/browser/src/transports/fetch.ts

@@ -1,9 +1,10 @@
 import { createTransport } from '@sentry/core';
-import { Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/types';
+import type { Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/types';
 import { rejectedSyncPromise } from '@sentry/utils';
 
-import { BrowserTransportOptions } from './types';
-import { clearCachedFetchImplementation, FetchImpl, getNativeFetchImplementation } from './utils';
+import type { BrowserTransportOptions } from './types';
+import type { FetchImpl } from './utils';
+import { clearCachedFetchImplementation, getNativeFetchImplementation } from './utils';
 
 /**
  * Creates a Transport that uses the Fetch API to send events to Sentry.

packages/browser/src/transports/types.ts

@@ -1,4 +1,4 @@
-import { BaseTransportOptions } from '@sentry/types';
+import type { BaseTransportOptions } from '@sentry/types';
 
 export interface BrowserTransportOptions extends BaseTransportOptions {
   /** Fetch API init parameters. Used by the FetchTransport */

packages/browser/src/transports/xhr.ts

@@ -1,8 +1,8 @@
 import { createTransport } from '@sentry/core';
-import { Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/types';
+import type { Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/types';
 import { SyncPromise } from '@sentry/utils';
 
-import { BrowserTransportOptions } from './types';
+import type { BrowserTransportOptions } from './types';
 
 /**
  * The DONE ready state for XmlHttpRequest

packages/browser/test/unit/eventbuilder.test.ts

@@ -1,4 +1,4 @@
-import { Client } from '@sentry/types';
+import type { Client } from '@sentry/types';
 
 import { defaultStackParser } from '../../src';
 import { eventFromPlainObject } from '../../src/eventbuilder';

packages/browser/test/unit/helper/browser-client-options.ts

@@ -1,7 +1,7 @@
 import { createTransport } from '@sentry/core';
 import { resolvedSyncPromise } from '@sentry/utils';
 
-import { BrowserClientOptions } from '../../../src/client';
+import type { BrowserClientOptions } from '../../../src/client';
 
 export function getDefaultBrowserClientOptions(options: Partial<BrowserClientOptions> = {}): BrowserClientOptions {
   return {

packages/browser/test/unit/index.test.ts

@@ -1,13 +1,13 @@
 import { getReportDialogEndpoint, SDK_VERSION } from '@sentry/core';
 
+import type { Event } from '../../src';
 import {
   addBreadcrumb,
   BrowserClient,
   captureEvent,
   captureException,
   captureMessage,
   configureScope,
-  Event,
   flush,
   getCurrentHub,
   init,

packages/browser/test/unit/integrations/helpers.test.ts

@@ -1,4 +1,4 @@
-import { WrappedFunction } from '@sentry/types';
+import type { WrappedFunction } from '@sentry/types';
 import { spy } from 'sinon';
 
 import { wrap } from '../../../src/helpers';

packages/browser/test/unit/integrations/linkederrors.test.ts

@@ -1,4 +1,4 @@
-import { Event as SentryEvent, Exception, ExtendedError } from '@sentry/types';
+import type { Event as SentryEvent, Exception, ExtendedError } from '@sentry/types';
 
 import { BrowserClient } from '../../../src/client';
 import * as LinkedErrorsModule from '../../../src/integrations/linkederrors';

packages/browser/test/unit/sdk.test.ts

@@ -1,10 +1,10 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import { createTransport, Scope } from '@sentry/core';
 import { MockIntegration } from '@sentry/core/test/lib/sdk.test';
-import { Client, Integration } from '@sentry/types';
+import type { Client, Integration } from '@sentry/types';
 import { resolvedSyncPromise } from '@sentry/utils';
 
-import { BrowserOptions } from '../../src';
+import type { BrowserOptions } from '../../src';
 import { init } from '../../src/sdk';
 
 const PUBLIC_DSN = 'https://username@domain/123';

packages/browser/test/unit/transports/fetch.test.ts

@@ -1,10 +1,10 @@
-import { EventEnvelope, EventItem } from '@sentry/types';
+import type { EventEnvelope, EventItem } from '@sentry/types';
 import { createEnvelope, serializeEnvelope } from '@sentry/utils';
 import { TextEncoder } from 'util';
 
 import { makeFetchTransport } from '../../../src/transports/fetch';
-import { BrowserTransportOptions } from '../../../src/transports/types';
-import { FetchImpl } from '../../../src/transports/utils';
+import type { BrowserTransportOptions } from '../../../src/transports/types';
+import type { FetchImpl } from '../../../src/transports/utils';
 
 const DEFAULT_FETCH_TRANSPORT_OPTIONS: BrowserTransportOptions = {
   url: 'https://sentry.io/api/42/store/?sentry_key=123&sentry_version=7',

packages/browser/test/unit/transports/xhr.test.ts

@@ -1,8 +1,8 @@
-import { EventEnvelope, EventItem } from '@sentry/types';
+import type { EventEnvelope, EventItem } from '@sentry/types';
 import { createEnvelope, serializeEnvelope } from '@sentry/utils';
 import { TextEncoder } from 'util';
 
-import { BrowserTransportOptions } from '../../../src/transports/types';
+import type { BrowserTransportOptions } from '../../../src/transports/types';
 import { makeXHRTransport } from '../../../src/transports/xhr';
 
 const DEFAULT_XHR_TRANSPORT_OPTIONS: BrowserTransportOptions = {

packages/core/src/api.ts

@@ -1,4 +1,4 @@
-import { ClientOptions, DsnComponents, DsnLike, SdkInfo } from '@sentry/types';
+import type { ClientOptions, DsnComponents, DsnLike, SdkInfo } from '@sentry/types';
 import { dsnToString, makeDsn, urlEncode } from '@sentry/utils';
 
 const SENTRY_API_VERSION = '7';

packages/core/src/baseclient.ts

@@ -1,5 +1,5 @@
 /* eslint-disable max-lines */
-import {
+import type {
   Client,
   ClientOptions,
   DataCategory,
@@ -37,8 +37,9 @@ import {
 
 import { getEnvelopeEndpointWithUrlEncodedAuth } from './api';
 import { createEventEnvelope, createSessionEnvelope } from './envelope';
-import { IntegrationIndex, setupIntegration, setupIntegrations } from './integration';
-import { Scope } from './scope';
+import type { IntegrationIndex } from './integration';
+import { setupIntegration, setupIntegrations } from './integration';
+import type { Scope } from './scope';
 import { updateSession } from './session';
 import { prepareEvent } from './utils/prepareEvent';
 

packages/core/src/envelope.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   DsnComponents,
   Event,
   EventEnvelope,

packages/core/src/exports.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   Breadcrumb,
   CaptureContext,
   CustomSamplingContext,
@@ -13,8 +13,9 @@ import {
   User,
 } from '@sentry/types';
 
-import { getCurrentHub, Hub } from './hub';
-import { Scope } from './scope';
+import type { Hub } from './hub';
+import { getCurrentHub } from './hub';
+import type { Scope } from './scope';
 
 // Note: All functions in this file are typed with a return value of `ReturnType<Hub[HUB_FUNCTION]>`,
 // where HUB_FUNCTION is some method on the Hub class.

packages/core/src/hub.ts

@@ -1,5 +1,5 @@
 /* eslint-disable max-lines */
-import {
+import type {
   Breadcrumb,
   BreadcrumbHint,
   Client,

packages/core/src/integration.ts

@@ -1,4 +1,4 @@
-import { Integration, Options } from '@sentry/types';
+import type { Integration, Options } from '@sentry/types';
 import { arrayify, logger } from '@sentry/utils';
 
 import { getCurrentHub } from './hub';

packages/core/src/integrations/functiontostring.ts

@@ -1,4 +1,4 @@
-import { Integration, WrappedFunction } from '@sentry/types';
+import type { Integration, WrappedFunction } from '@sentry/types';
 import { getOriginalFunction } from '@sentry/utils';
 
 let originalFunctionToString: () => void;

packages/core/src/integrations/inboundfilters.ts

@@ -1,4 +1,4 @@
-import { Event, EventProcessor, Hub, Integration, StackFrame } from '@sentry/types';
+import type { Event, EventProcessor, Hub, Integration, StackFrame } from '@sentry/types';
 import { getEventDescription, logger, stringMatchesSomePattern } from '@sentry/utils';
 
 // "Script error." is hard coded into browsers for errors that it can't read.

packages/core/src/scope.ts

@@ -1,5 +1,5 @@
 /* eslint-disable max-lines */
-import {
+import type {
   Attachment,
   Breadcrumb,
   CaptureContext,

packages/core/src/sdk.ts

@@ -1,4 +1,4 @@
-import { Client, ClientOptions } from '@sentry/types';
+import type { Client, ClientOptions } from '@sentry/types';
 import { logger } from '@sentry/utils';
 
 import { getCurrentHub } from './hub';

packages/core/src/session.ts

@@ -1,4 +1,4 @@
-import { SerializedSession, Session, SessionContext, SessionStatus } from '@sentry/types';
+import type { SerializedSession, Session, SessionContext, SessionStatus } from '@sentry/types';
 import { dropUndefinedKeys, timestampInSeconds, uuid4 } from '@sentry/utils';
 
 /**

packages/core/src/sessionflusher.ts

@@ -1,4 +1,10 @@
-import { AggregationCounts, Client, RequestSessionStatus, SessionAggregates, SessionFlusherLike } from '@sentry/types';
+import type {
+  AggregationCounts,
+  Client,
+  RequestSessionStatus,
+  SessionAggregates,
+  SessionFlusherLike,
+} from '@sentry/types';
 import { dropUndefinedKeys } from '@sentry/utils';
 
 import { getCurrentHub } from './hub';