Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong tab selector label per command on install page for react sdk #9486

Closed
arnoproblems opened this issue Mar 19, 2024 · 3 comments
Closed

Wrong tab selector label per command on install page for react sdk #9486

arnoproblems opened this issue Mar 19, 2024 · 3 comments

Comments

@arnoproblems
Copy link

Core or SDK?

Platform/SDK

Which part? Which one?

react sdk

Description

The tab label doesn't match with the command.

here: https://docs.sentry.io/platforms/javascript/guides/react/

image

Suggested Solution

switch labels or switch commands
@getsantry
Copy link
Contributor

getsantry bot commented Mar 19, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 2 Mar 19, 2024
@Shubhdeep12 Shubhdeep12 mentioned this issue Mar 19, 2024
Closed
3 tasks
@Shubhdeep12
Copy link
Contributor

Shubhdeep12 commented Mar 19, 2024 •
edited
Loading

Looks like this has impacted the app, and this is the impact of #9367
I've raised a PR for the fix and removed the sorting of tab names while creating key names for localstorage

cc @lizokm

@Shubhdeep12
Copy link
Contributor

Sorry i missed checking the opened PRs
the PR for the fix is already opened here - #9481

closing this one.

@a-hariti a-hariti mentioned this issue Mar 19, 2024
Merged
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
GitHub Issues with 👀 2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(codetabs): removed sorting of tabs in codetabs Shubhdeep12/sentry-docs
3 participants
@a-hariti @Shubhdeep12 @arnoproblems