Fix system error from invalid function handle (#29654)

GitOrigin-RevId: ba897bcf2514b587a94d6f1dbd36e00ba2baf79e

Author: Sujay Jayakar

crates/isolate/src/environment/action/async_syscall.rs

@@ -115,7 +115,7 @@ impl<RT: Runtime> TaskExecutor<RT> {
                     .await?
             },
             None => {
-                let reference = parse_name_or_reference(name, reference)?;
+                let reference = parse_name_or_reference("runQuery", name, reference)?;
                 self.resolve_function(&reference)?
             },
         };
@@ -160,7 +160,7 @@ impl<RT: Runtime> TaskExecutor<RT> {
                     .await?
             },
             None => {
-                let reference = parse_name_or_reference(name, reference)?;
+                let reference = parse_name_or_reference("runMutation", name, reference)?;
                 self.resolve_function(&reference)?
             },
         };
@@ -202,7 +202,7 @@ impl<RT: Runtime> TaskExecutor<RT> {
                     .await?
             },
             None => {
-                let reference = parse_name_or_reference(name, reference)?;
+                let reference = parse_name_or_reference("runAction", name, reference)?;
                 self.resolve_function(&reference)?
             },
         };
@@ -246,9 +246,7 @@ impl<RT: Runtime> TaskExecutor<RT> {
                     .await?
             },
             None => {
-                let reference = with_argument_error("scheduler", || {
-                    parse_name_or_reference(name, reference).context(ArgName("name"))
-                })?;
+                let reference = parse_name_or_reference("scheduler", name, reference)?;
                 self.resolve_function(&reference)?
             },
         };
@@ -425,7 +423,7 @@ impl<RT: Runtime> TaskExecutor<RT> {
                 return Ok(serde_json::to_value(function_handle)?);
             },
             None => {
-                let reference = parse_name_or_reference(name, reference)?;
+                let reference = parse_name_or_reference("createFunctionHandle", name, reference)?;
                 self.resolve_function(&reference)?
             },
         };
@@ -441,12 +439,13 @@ impl<RT: Runtime> TaskExecutor<RT> {
 }
 
 pub fn parse_name_or_reference(
+    function_name: &str,
     name: Option<String>,
     reference: Option<String>,
 ) -> anyhow::Result<Reference> {
-    match (name, reference) {
+    with_argument_error(function_name, || match (name, reference) {
         (Some(name), _) => Ok(Reference::Function(name.parse()?)),
         (_, Some(reference)) => Ok(reference.parse()?),
         _ => anyhow::bail!("Missing required argument 'name'"),
-    }
+    })
 }

crates/isolate/src/environment/udf/async_syscall.rs

@@ -873,9 +873,7 @@ impl<RT: Runtime, P: AsyncSyscallProvider<RT>> DatabaseSyscallsV1<RT, P> {
                 provider.lookup_function_handle(handle).await?
             },
             None => {
-                let reference = with_argument_error("scheduler", || {
-                    parse_name_or_reference(name, reference).context(ArgName("name"))
-                })?;
+                let reference = parse_name_or_reference("scheduler", name, reference)?;
                 match provider.resolve(reference).await? {
                     Resource::Value(v) => {
                         anyhow::bail!(ErrorMetadata::bad_request(
@@ -1270,8 +1268,7 @@ impl<RT: Runtime, P: AsyncSyscallProvider<RT>> DatabaseSyscallsV1<RT, P> {
                 }
             },
             None => {
-                let reference =
-                    parse_name_or_reference(name, reference).context(ArgName("name"))?;
+                let reference = parse_name_or_reference("runUdf", name, reference)?;
                 let resource = provider.resolve(reference).await?;
                 match resource {
                     Resource::ResolvedSystemUdf(path) => path,
@@ -1319,7 +1316,7 @@ impl<RT: Runtime, P: AsyncSyscallProvider<RT>> DatabaseSyscallsV1<RT, P> {
                 return Ok(serde_json::to_value(function_handle)?);
             },
             None => {
-                let reference = parse_name_or_reference(name, reference)?;
+                let reference = parse_name_or_reference("createFunctionHandle", name, reference)?;
                 match provider.resolve(reference).await? {
                     Resource::Function(path) => path,
                     Resource::ResolvedSystemUdf { .. } => {