SerializedComponentDiff::index_diff is optional (#29976)

there are some audit log documents where this field is missing. we could migrate them to have the field, but it's easier to accept that they might not exist and handle it. Should fix db-verifier and also dashboard for these instances.

GitOrigin-RevId: 5dbd45b2b4e620a14e3cc9c3b5939dd0cb1416d0

Author: ldanilek

crates/model/src/components/config.rs

@@ -852,7 +852,7 @@ pub struct SerializedComponentDiff {
     module_diff: ModuleDiff,
     udf_config_diff: Option<UdfServerVersionDiff>,
     cron_diff: CronDiff,
-    index_diff: SerializedIndexDiff,
+    index_diff: Option<SerializedIndexDiff>,
     schema_diff: Option<SerializedSchemaDiff>,
 }
 
@@ -891,7 +891,7 @@ impl TryFrom<ComponentDiff> for SerializedComponentDiff {
             module_diff: value.module_diff,
             udf_config_diff: value.udf_config_diff,
             cron_diff: value.cron_diff,
-            index_diff: value.index_diff.try_into()?,
+            index_diff: Some(value.index_diff.try_into()?),
             schema_diff: value.schema_diff.map(|diff| diff.try_into()).transpose()?,
         })
     }
@@ -906,7 +906,10 @@ impl TryFrom<SerializedComponentDiff> for ComponentDiff {
             module_diff: value.module_diff,
             udf_config_diff: value.udf_config_diff,
             cron_diff: value.cron_diff,
-            index_diff: value.index_diff.try_into()?,
+            index_diff: match value.index_diff {
+                Some(index_diff) => index_diff.try_into()?,
+                None => AuditLogIndexDiff::default(),
+            },
             schema_diff: value.schema_diff.map(|diff| diff.try_into()).transpose()?,
         })
     }

crates/model/src/deployment_audit_log/types.rs

@@ -65,7 +65,7 @@ pub static DEPLOYMENT_AUDIT_LOG_TABLE: LazyLock<TableName> = LazyLock::new(|| {
         .expect("Invalid deployment audit log table")
 });
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Default)]
 #[cfg_attr(any(test, feature = "testing"), derive(proptest_derive::Arbitrary))]
 pub struct AuditLogIndexDiff {
     #[cfg_attr(

npm-packages/convex/src/cli/lib/components.ts

@@ -419,7 +419,7 @@ function printDiff(
 
   // Print out index diffs for the root component.
   let rootDiff = componentDiffs[""];
-  if (rootDiff) {
+  if (rootDiff && rootDiff.indexDiff) {
     if (rootDiff.indexDiff.removed_indexes.length > 0) {
       let msg = `${opts.dryRun ? "Would delete" : "Deleted"} table indexes:\n`;
       for (let i = 0; i < rootDiff.indexDiff.removed_indexes.length; i++) {

npm-packages/system-udfs/convex/tableDefs/deploymentAuditLogTable.ts

@@ -129,7 +129,7 @@ export const componentDiff = v.object({
       v.literal("remount"),
     ),
   }),
-  indexDiff: indexDiff,
+  indexDiff: v.optional(indexDiff),
   udfConfigDiff: serverVersion,
   moduleDiff: moduleDiff,
   cronDiff: cronDiffType,