Fix ordering on retention manager shutdown (#24346)

jordanhunt22 · Convex, Inc. · commit bcc9b9928a3d · 2024-04-06T01:22:36.000Z
GitOrigin-RevId: 1ade3a6bb1d42d3c904bb05fe65668b2c1729133
diff --git a/crates/database/src/retention.rs b/crates/database/src/retention.rs
@@ -352,9 +352,9 @@ impl<RT: Runtime> LeaderRetentionManager<RT> {
     }
 
     pub fn shutdown(&self) {
-        self.advance_min_snapshot_handle.lock().shutdown();
         self.deletion_handle.lock().shutdown();
         self.document_deletion_handle.lock().shutdown();
+        self.advance_min_snapshot_handle.lock().shutdown();
     }
 
     /// Returns the timestamp which we would like to use as min_snapshot_ts.

Original file line number	Diff line number	Diff line change
`@@ -352,9 +352,9 @@ impl<RT: Runtime> LeaderRetentionManager<RT> {`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`pub fn shutdown(&self) {`
`355`		`- self.advance_min_snapshot_handle.lock().shutdown();`
`356`	`355`	`self.deletion_handle.lock().shutdown();`
`357`	`356`	`self.document_deletion_handle.lock().shutdown();`
	`357`	`+ self.advance_min_snapshot_handle.lock().shutdown();`
`358`	`358`	`}`
`359`	`359`
`360`	`360`	`/// Returns the timestamp which we would like to use as min_snapshot_ts.`