Remove unused table filters from convex_api (#37312)

GitOrigin-RevId: fb8c986374d7695b436a9b41f11b817f75b74e7a

Author: Nicolapps

crates/fivetran_source/src/convex_api.rs

@@ -51,14 +51,12 @@ pub trait Source: Display + Send {
         &self,
         snapshot: Option<i64>,
         cursor: Option<ListSnapshotCursor>,
-        table_name: Option<String>,
     ) -> anyhow::Result<ListSnapshotResponse>;
 
     /// See https://docs.convex.dev/http-api/#get-apidocument_deltas
     async fn document_deltas(
         &self,
         cursor: DocumentDeltasCursor,
-        table_name: Option<String>,
     ) -> anyhow::Result<DocumentDeltasResponse>;
 
     /// Get a list of columns for each table on the Convex backend.
@@ -170,14 +168,13 @@ impl Source for ConvexApi {
         &self,
         snapshot: Option<i64>,
         cursor: Option<ListSnapshotCursor>,
-        table_name: Option<String>,
     ) -> anyhow::Result<ListSnapshotResponse> {
         self.post(
             "list_snapshot",
             ListSnapshotArgs {
                 snapshot,
                 cursor: cursor.map(|c| c.into()),
-                table_name,
+                table_name: None,
                 component: None,
                 format: Some("convex_encoded_json".to_string()),
             },
@@ -188,13 +185,12 @@ impl Source for ConvexApi {
     async fn document_deltas(
         &self,
         cursor: DocumentDeltasCursor,
-        table_name: Option<String>,
     ) -> anyhow::Result<DocumentDeltasResponse> {
         self.post(
             "document_deltas",
             DocumentDeltasArgs {
                 cursor: Some(cursor.into()),
-                table_name,
+                table_name: None,
                 component: None,
                 format: Some("convex_encoded_json".to_string()),
             },

crates/fivetran_source/src/sync.rs

@@ -171,7 +171,7 @@ async fn initial_sync(
     let snapshot = loop {
         let snapshot = checkpoint.as_ref().map(|c| c.0);
         let cursor = checkpoint.as_ref().map(|c| c.1.clone());
-        let res = source.list_snapshot(snapshot, cursor.clone(), None).await?;
+        let res = source.list_snapshot(snapshot, cursor.clone()).await?;
 
         for value in res.values {
             if let Some(ref mut tables_seen) = tables_seen {
@@ -236,7 +236,7 @@ async fn delta_sync(
     let mut cursor = cursor;
     let mut has_more = true;
     while has_more {
-        let response = source.document_deltas(cursor, None).await?;
+        let response = source.document_deltas(cursor).await?;
 
         for value in response.values {
             if let Some(ref mut tables_seen) = tables_seen {

crates/fivetran_source/src/tests.rs

@@ -182,12 +182,7 @@ impl Source for FakeSource {
         &self,
         snapshot: Option<i64>,
         cursor: Option<ListSnapshotCursor>,
-        table_name: Option<String>,
     ) -> anyhow::Result<ListSnapshotResponse> {
-        if table_name.is_some() {
-            panic!("Query by table is not supported by the fake");
-        }
-
         if snapshot.is_some() && snapshot != Some(self.changelog.len() as i64) {
             panic!("Unexpected snapshot value");
         }
@@ -222,12 +217,7 @@ impl Source for FakeSource {
     async fn document_deltas(
         &self,
         cursor: DocumentDeltasCursor,
-        table_name: Option<String>,
     ) -> anyhow::Result<DocumentDeltasResponse> {
-        if table_name.is_some() {
-            panic!("Per-table log not supported in fake");
-        }
-
         let results_per_page = 5;
         let values: Vec<DocumentDeltasValue> = self
             .changelog
@@ -550,21 +540,17 @@ impl Source for UnreliableSource {
         &self,
         snapshot: Option<i64>,
         cursor: Option<ListSnapshotCursor>,
-        table_name: Option<String>,
     ) -> anyhow::Result<ListSnapshotResponse> {
         self.maybe_fail()?;
-        self.source
-            .list_snapshot(snapshot, cursor, table_name)
-            .await
+        self.source.list_snapshot(snapshot, cursor).await
     }
 
     async fn document_deltas(
         &self,
         cursor: DocumentDeltasCursor,
-        table_name: Option<String>,
     ) -> anyhow::Result<DocumentDeltasResponse> {
         self.maybe_fail()?;
-        self.source.document_deltas(cursor, table_name).await
+        self.source.document_deltas(cursor).await
     }
 
     async fn get_tables_and_columns(&self) -> anyhow::Result<BTreeMap<TableName, Vec<FieldName>>> {