Skip to content

Commit 8fcd070

Browse files
emmaling27Convex, Inc.
authored and
Convex, Inc.
committed
Enable tests for multisegment text search path (#26441)
This PR fixes search scoring to work for multisegment search query path. GitOrigin-RevId: dc744089b870ff3abe6da79738834eed041ca7d2
1 parent 2b121fb commit 8fcd070

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

crates/database/src/tests/randomized_search_tests.rs

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -603,15 +603,26 @@ async fn test_search_score(rt: TestRuntime) -> anyhow::Result<()> {
603603
.await?;
604604
assert_eq!(results.len(), 1);
605605

606-
// Constant taken from https://github.com/quickwit-oss/tantivy/blob/main/src/query/term_query/mod.rs#L20
607-
assert_approx_equal(results.first().unwrap().1, 1.);
606+
// Search scoring will be different with multisegment search query.
607+
if std::env::var("USE_MULTI_SEGMENT_SEARCH_QUERY").is_ok() {
608+
assert_approx_equal(results.first().unwrap().1, 0.2876);
609+
} else {
610+
// Constant taken from https://github.com/quickwit-oss/tantivy/blob/main/src/query/term_query/mod.rs#L20
611+
assert_approx_equal(results.first().unwrap().1, 1.);
612+
}
608613
}
609614
{
610615
let results = scenario
611616
.query_with_scores(&query, None, SearchVersion::V2)
612617
.await?;
613618
assert_eq!(results.len(), 1);
614-
assert_approx_equal(results.first().unwrap().1, 1.);
619+
// Search scoring will be different with multisegment search query.
620+
if std::env::var("USE_MULTI_SEGMENT_SEARCH_QUERY").is_ok() {
621+
assert_approx_equal(results.first().unwrap().1, 0.2876);
622+
} else {
623+
// Constant taken from https://github.com/quickwit-oss/tantivy/blob/main/src/query/term_query/mod.rs#L20
624+
assert_approx_equal(results.first().unwrap().1, 1.);
625+
}
615626
}
616627
anyhow::Ok(())
617628
}

0 commit comments

Comments
 (0)