switch to mkdirSync in node executor (#37330)

gautamg795 · Convex, Inc. · commit 8ed01d530235 · 2025-05-15T21:52:08.000Z
this may not fix anything, but it should at least reveal the real error rather than ENOENT

GitOrigin-RevId: 6338acf833fa22ed31151d58a31a6f0542be1e4a
diff --git a/npm-packages/node-executor/src/source_package.ts b/npm-packages/node-executor/src/source_package.ts
@@ -211,7 +211,8 @@ async function maybeDownloadExternalPackage(
 
 async function createFreshDir(dir: string) {
   await fs.promises.rm(dir, { recursive: true, force: true });
-  await fs.promises.mkdir(dir, { recursive: true, mode: 0o744 });
+  // fs.promises.mkdir sometimes fails with ENOENT (the real error might be ENOSPC, but we're not sure)
+  fs.mkdirSync(dir, { recursive: true, mode: 0o744 });
 }
 
 async function streamToBuffer(

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,8 @@ async function maybeDownloadExternalPackage(`
`211`	`211`
`212`	`212`	`async function createFreshDir(dir: string) {`
`213`	`213`	`await fs.promises.rm(dir, { recursive: true, force: true });`
`214`		`- await fs.promises.mkdir(dir, { recursive: true, mode: 0o744 });`
	`214`	`+ // fs.promises.mkdir sometimes fails with ENOENT (the real error might be ENOSPC, but we're not sure)`
	`215`	`+ fs.mkdirSync(dir, { recursive: true, mode: 0o744 });`
`215`	`216`	`}`
`216`	`217`
`217`	`218`	`async function streamToBuffer(`