Skip to content

Commit 86ca391

Browse files
sjuddConvex, Inc.
authored and
Convex, Inc.
committed
Clean up dead code in build disk index (#27127)
GitOrigin-RevId: 9fc756754799d52167d01d3dc8e01be2b0a5f76d
1 parent 3b57a5b commit 86ca391

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

crates/search/src/incremental_index.rs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -364,14 +364,6 @@ pub async fn build_new_segment<RT: Runtime>(
364364
// deleted within our new segment's time window and can be ignored.
365365
let mut dangling_deletes = BTreeSet::new();
366366

367-
// Keep track of deleted document ids whose previous revision was within our
368-
// document log window for this new segment. We can't process previous
369-
// revisions inside of our document window because mutations to the document
370-
// may mean it has terms that don't match those in the previous segment. Use
371-
// this set to skip deletes until we find the first delete for a given id
372-
// whose previous revision's timestamp is outside our window.
373-
// let mut pending_deletes = BTreeSet::new();
374-
375367
let mut num_indexed_documents = 0;
376368

377369
let mut is_at_least_one_document_indexed = false;
@@ -382,8 +374,7 @@ pub async fn build_new_segment<RT: Runtime>(
382374
// 1. We add the document to our new segment
383375
// 2. We delete the document from a previous segment
384376
// 3. We ignore the document because it was both added and removed within the
385-
// time bounds
386-
// for our new segment.
377+
// time bounds for our new segment.
387378
let convex_id = revision_pair.id.internal_id();
388379

389380
// Skip documents we have already added to the segment, but update dangling

0 commit comments

Comments
 (0)