Make nextRun in crons system UDF required (#36390)

GitOrigin-RevId: bd9ab9997aa2020e6d13b252d17aa15fbf99aec1

Author: sshader

npm-packages/dashboard-common/src/features/schedules/components/crons/CronJobsContent.tsx

@@ -100,7 +100,7 @@ function Details({
     delete router.query.id;
     void router.push({ query: router.query });
   };
-  const currentlyRunning = cronJob.nextRun?.state.type === "inProgress";
+  const currentlyRunning = cronJob.nextRun.state.type === "inProgress";
 
   return (
     <div className="flex h-full w-full max-w-6xl flex-col gap-4">
@@ -201,11 +201,9 @@ export function TopCronJobLogListItem({
   const url = useFunctionUrl(cronJob.cronSpec.udfPath);
 
   const { nextRun } = cronJob;
-  const nextTs = nextRun?.nextTs;
-  const timestamp = nextTs
-    ? formatDateTime(new Date(Number(nextTs / BigInt(1000000))))
-    : null;
-  const currentlyRunning = nextRun?.state.type === "inProgress";
+  const { nextTs, state } = nextRun;
+  const timestamp = formatDateTime(new Date(Number(nextTs / BigInt(1000000))));
+  const currentlyRunning = state.type === "inProgress";
 
   // Make a quickly-updating timer to make function execution feel fast.
   // To avoid a React render every frame (often fine but can gum things up),

npm-packages/dashboard-common/src/features/schedules/components/crons/CronsTable.tsx

@@ -136,10 +136,10 @@ function PrevNextTs({
     nextDate: Date | undefined;
     prevDate: Date;
     prevRun: CronJobLog | undefined;
-    nextRun: Doc<"_cron_next_run"> | undefined;
+    nextRun: Doc<"_cron_next_run">;
   }
 >) {
-  const isRunning = value.nextRun?.state.type === "inProgress";
+  const isRunning = value.nextRun.state.type === "inProgress";
   return (
     <div className="flex flex-col truncate">
       <PrevTs date={value.prevDate} isRunning={isRunning} run={value.prevRun} />
@@ -208,9 +208,7 @@ function Args({ value }: CellProps<CronDatum, JSONValue[]>) {
 
 function cronDatum(cronJob: CronJobWithRuns) {
   const { name, cronSpec, lastRun, nextRun } = cronJob;
-  const nextDate = nextRun
-    ? new Date(Number(nextRun.nextTs / BigInt("1000000")))
-    : undefined;
+  const nextDate = new Date(Number(nextRun.nextTs / BigInt("1000000")));
   const prevDate = lastRun && new Date(Number(lastRun.ts / BigInt("1000000")));
   return {
     name,
@@ -219,7 +217,7 @@ function cronDatum(cronJob: CronJobWithRuns) {
       prevDate,
       nextDate,
       prevRun: lastRun,
-      state: nextRun?.state,
+      state: nextRun.state,
     },
     udfPath: cronSpec.udfPath,
     udfArgs:

npm-packages/system-udfs/convex/_system/frontend/common.ts

@@ -97,9 +97,8 @@ export type CronSpec = Doc<"_cron_jobs">["cronSpec"];
 export type CronSchedule = Doc<"_cron_jobs">["cronSpec"]["cronSchedule"];
 export type CronJobLog = Doc<"_cron_job_logs">;
 export type CronJobWithRuns = Doc<"_cron_jobs"> & {
-  // only undefined while feature-flagged (but still might be null)
-  lastRun: CronJobLog | null | undefined;
-  nextRun: Doc<"_cron_next_run"> | null | undefined;
+  lastRun: CronJobLog | null;
+  nextRun: Doc<"_cron_next_run">;
 };
 
 export type Modules = Map<string, Module>;

npm-packages/system-udfs/convex/_system/frontend/listCronJobs.ts

@@ -17,6 +17,9 @@ export default queryPrivateSystem({
         .query("_cron_next_run")
         .withIndex("by_cron_job_id", (q) => q.eq("cronJobId", job._id))
         .first();
+      if (nextRun === null) {
+        throw new Error("No next run found for cron job");
+      }
       jobsWithRuns.push({
         ...job,
         lastRun: lastRun,