sanitize passHref from defaultlink (#36433)

atrakh · Convex, Inc. · commit 6134c9c199ef · 2025-04-15T22:31:13.000Z
GitOrigin-RevId: d3c5617eafc3049c030dac0f3878bc3651c77c4c
diff --git a/npm-packages/@convex-dev/design-system/package.json b/npm-packages/@convex-dev/design-system/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@convex-dev/design-system",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "type": "module",
   "sideEffects": false,
   "files": [
diff --git a/npm-packages/@convex-dev/design-system/src/UIContext.tsx b/npm-packages/@convex-dev/design-system/src/UIContext.tsx
@@ -1,3 +1,4 @@
+import { omit } from "lodash-es";
 import {
   ComponentType,
   createContext,
@@ -45,7 +46,7 @@ function DefaultLink({
           ? href
           : `${href.pathname}${encodeQuery(href.query)}${href.hash || ""}`
       }
-      {...props}
+      {...omit(props, "passHref")}
     >
       {children}
     </a>

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@convex-dev/design-system",`
`3`		`- "version": "0.1.3",`
	`3`	`+ "version": "0.1.4",`
`4`	`4`	`"type": "module",`
`5`	`5`	`"sideEffects": false,`
`6`	`6`	`"files": [`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+import { omit } from "lodash-es";`
`1`	`2`	`import {`
`2`	`3`	`ComponentType,`
`3`	`4`	`createContext,`
`@@ -45,7 +46,7 @@ function DefaultLink({`
`45`	`46`	`? href`
`46`	`47`	: `${href.pathname}${encodeQuery(href.query)}${href.hash \|\| ""}`
`47`	`48`	`}`
`48`		`- {...props}`
	`49`	`+ {...omit(props, "passHref")}`
`49`	`50`	`>`
`50`	`51`	`{children}`
`51`	`52`	`</a>`