Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session cannot handle multiple transactions #16

Open
duobradovic opened this issue Mar 17, 2024 · 1 comment
Open

Session cannot handle multiple transactions #16

duobradovic opened this issue Mar 17, 2024 · 1 comment

Comments

@duobradovic
Copy link

duobradovic commented Mar 17, 2024

Smtp supports multiple transactions per single connection, consider following example:

C: helo
C: mail from
C: rcpt to
C: data
C: rset
C: mail from
...

Purepythonmilter does not reset session state after end-of-data. After 'Continue' response to End of Data Postfix sends SMFIC_ABORT, this is meant to signal milter to reset session to a clean state.

SMFIC_ABORT is also sent after Smtp transaction RSET:
C: helo
C: mail from
C: rcpt to
C: rset
C: mail from
...

Since the milters' session is not reset, any existing session header 'manipulations' remains.

@duobradovic
Copy link
Author

'MtaMilterSession' should at the very least reset, '_pending_manipulations' and '_manipulations_sent'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant