Skip to content

duplicated schema-org annotation & parsing failure #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvgenuchten opened this issue Nov 18, 2020 · 3 comments · Fixed by #575 or #576
Closed

duplicated schema-org annotation & parsing failure #574

pvgenuchten opened this issue Nov 18, 2020 · 3 comments · Fixed by #575 or #576
Labels
enhancement New feature or request

Comments

@pvgenuchten
Copy link
Contributor

Some observations when validating https://demo.pygeoapi.io/master/collections/lakes in https://search.google.com/structured-data/testing-tool

Duplicated annotation
The pygeoapi templates still have microdata 'itemscope' attributes, combined with the embedded json-ld, it leads to duplicated parsing in validation tools. validator extracts the same dataset information twice

image

Parse error

The embedded json-ld throws a parse error on

 "@context": "https://schema.org/docs/jsonldcontext.jsonld",

error:

There was an invalid type in your JSON-LD.

This results in the object described being a:
image

In other implementations I notice this string seems to work fine:

"@context": "http://schema.org/",

In that case the type is recognized as:
image

@alpha-beta-soup
Copy link
Contributor

See #444

@pvgenuchten
Copy link
Contributor Author

#575 had negative side-effect, so we should keep this open

@pvgenuchten pvgenuchten reopened this Dec 1, 2020
tomkralidis pushed a commit that referenced this issue Dec 1, 2020
* google expects plain schema-org url
https://yoast.com/json-ld/
resolves #574

* Revert "google expects plain schema-org url"

This reverts commit 7f09d4c.

* hack to replace full path for short path, because pyld requires full, search engine expects short
@pvgenuchten
Copy link
Contributor Author

confirming here that the merge made datasets crawlable again through google tooling

image

pvgenuchten pushed a commit to pvgenuchten/pygeoapi that referenced this issue Jan 18, 2021
* google expects plain schema-org url
https://yoast.com/json-ld/
resolves geopython#574

* Revert "google expects plain schema-org url"

This reverts commit 7f09d4c.

* hack to replace full path for short path, because pyld requires full, search engine expects short
francbartoli pushed a commit to francbartoli/pygeoapi that referenced this issue Jul 8, 2021
* google expects plain schema-org url
https://yoast.com/json-ld/
resolves geopython#574

* Revert "google expects plain schema-org url"

This reverts commit 7f09d4c.

* hack to replace full path for short path, because pyld requires full, search engine expects short
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants