Skip to content

Commit 676a401

Browse files
committed
Revert "[GraphHopper] Add GraphHopperProvider enum for provider options of GraphHopper geocoding api"
This reverts commit 320b5d7.
1 parent 320b5d7 commit 676a401

File tree

3 files changed

+1
-44
lines changed

3 files changed

+1
-44
lines changed

Diff for: src/Provider/GraphHopper/GraphHopper.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public function geocodeQuery(GeocodeQuery $query): Collection
7575
}
7676

7777
$provider = $query->getData('provider');
78-
if (is_string($provider) && GraphHopperProvider::tryFrom($provider)) {
78+
if (is_string($provider) && '' !== $provider) {
7979
$url .= sprintf('&provider=%s', urlencode($provider));
8080
}
8181

Diff for: src/Provider/GraphHopper/GraphHopperProvider.php

-14
This file was deleted.

Diff for: src/Provider/GraphHopper/Tests/GraphHopperTest.php

-29
Original file line numberDiff line numberDiff line change
@@ -150,35 +150,6 @@ function (RequestInterface $request) use (&$uri) {
150150
);
151151
}
152152

153-
public function testNoProviderIsAppendedWhenProviderNotInEnum(): void
154-
{
155-
$uri = '';
156-
157-
$provider = new GraphHopper(
158-
$this->getMockedHttpClientCallback(
159-
function (RequestInterface $request) use (&$uri) {
160-
$uri = (string) $request->getUri();
161-
}
162-
),
163-
'api_key'
164-
);
165-
166-
$query = GeocodeQuery::create('242 Acklam Road, London, United Kingdom')
167-
->withLocale('fr')
168-
->withData('provider', 'invalidProvider');
169-
170-
try {
171-
$provider->geocodeQuery($query);
172-
} catch (InvalidServerResponse $e) {
173-
}
174-
175-
$this->assertEquals('https://graphhopper.com/api/1/geocode'.
176-
'?q=242+Acklam+Road%2C+London%2C+United+Kingdom'.
177-
'&key=api_key&locale=fr&limit=5',
178-
$uri
179-
);
180-
}
181-
182153
public function testReverseWithRealCoordinates(): void
183154
{
184155
if (!isset($_SERVER['GRAPHHOPPER_API_KEY'])) {

0 commit comments

Comments
 (0)