instruments that are disabled on account are now made tradable when s… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending an open request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the python sample file OpenPosition.py, it is common to run into the error of an instrument being "not valid," while in reality its status is disabled on that account. This can be confusing, with a vague message that doesn't point towards what is needed.
This request implements what is needed in error checking. Opening Positions on the fxcm trading website automatically makes the instrument tradable on the account if it's not, so I thought the sample script should do that as well. This pull request adds this functionality to the error checking- making an instrument tradable if it's disabled on the account.