Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault due to hard coded timeout values #23

Open
jaman opened this issue Jun 10, 2020 · 0 comments
Open

Segfault due to hard coded timeout values #23

jaman opened this issue Jun 10, 2020 · 0 comments

Comments

@jaman
Copy link

jaman commented Jun 10, 2020

SessionStatusListener.py, ResponseListener.py and TableManagerListener.py all have a hard-coded wait(30) in them. Under various circumstances, that wait can be exceeded. In such a case, the system can segfault and core-dump.

There are a number of issues here:

  • The end user is not given the option to set their own timeout for this value. This should be a parameter exposed in the constructor or other area that allows the user to set the value.
  • The segfault is not handled by the code in question.
  • Ideally, the error would be captured and sent back to the end user as an actionable message.

What should happen is:
Timeout -> 'Tablemanager timeout awaiting [possibly 5he callstack]. Waited ** seconds without response'
Now the client should be able to take that information and, increase the allowed timeout via the configurable value, re-evaluate the code their using to see if there is an issue, or reach out to FXCM to investigate issues with slow processing (in the case of things like orders).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant