Skip to content

Commit 17c7b0c

Browse files
committed
test : 테스트코드 변경 반영
1 parent b6d08d7 commit 17c7b0c

File tree

3 files changed

+4
-22
lines changed

3 files changed

+4
-22
lines changed

src/test/java/gdsc/konkuk/platformcore/application/email/EmailIntegrationTest.java

-21
Original file line numberDiff line numberDiff line change
@@ -161,27 +161,6 @@ void should_cancel_task() {
161161
() -> taskInMemoryRepository.getTask(emailTask.getId().toString()));
162162
}
163163

164-
@Test
165-
@DisplayName("이미 처리된 작업 취소 시도 시 예외 발생")
166-
void should_fail_when_cancel_already_processed_task() throws Exception {
167-
//given
168-
EmailSendRequest emailRequest = EmailSendRequestFixture.builder()
169-
.sendAt(LocalDateTime.now().plusSeconds(1)).build()
170-
.getFixture();
171-
172-
//when
173-
EmailTask scheduledTask = emailTaskFacade.register(emailRequest);
174-
sleep(2_000);
175-
176-
//then
177-
try {
178-
emailTaskFacade.cancel(scheduledTask.getId());
179-
fail("`TaskNotFoundException` or `EmailAlreadyProcessedException` should be thrown");
180-
} catch (TaskNotFoundException | EmailAlreadyProcessedException e) {
181-
// pass
182-
}
183-
}
184-
185164
@Test
186165
void should_send_discord_message_when_email_sending_error() throws InterruptedException {
187166
//given

src/test/java/gdsc/konkuk/platformcore/application/email/EmailTaskFacadeTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package gdsc.konkuk.platformcore.application.email;
22

3+
import static org.mockito.ArgumentMatchers.any;
34
import static org.mockito.BDDMockito.given;
45
import static org.mockito.BDDMockito.willDoNothing;
56
import static org.mockito.Mockito.verify;
7+
import static org.mockito.Mockito.when;
68
import static org.mockito.MockitoAnnotations.openMocks;
79

810
import gdsc.konkuk.platformcore.controller.email.dtos.EmailSendRequest;
@@ -70,6 +72,7 @@ void should_success_when_cancel_task() {
7072
EmailTask emailTaskToCancel = EmailTaskFixture.builder().build().getFixture();
7173
willDoNothing().given(emailTaskScheduler).cancelTask(emailTaskToCancel.getId().toString());
7274
willDoNothing().given(emailService).delete(emailTaskToCancel.getId());
75+
when(emailService.findById(any())).thenReturn(emailTaskToCancel);
7376

7477
//when
7578
subject.cancel(emailTaskToCancel.getId());

src/test/java/gdsc/konkuk/platformcore/controller/email/EmailControllerTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ void should_success_when_get_specific_task() throws Exception {
222222
String jwt = jwtTokenProvider.createToken(member);
223223
EmailTask emailTaskToSee = EmailTaskFixture.builder()
224224
.id(1L).build().getFixture();
225-
given(emailService.getTaskDetails(emailTaskToSee.getId()))
225+
given(emailService.findById(emailTaskToSee.getId()))
226226
.willReturn(emailTaskToSee);
227227

228228
//when

0 commit comments

Comments
 (0)