Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literature export gives an empty file #48

Open
gbif-portal opened this issue Nov 27, 2024 · 4 comments
Open

Literature export gives an empty file #48

gbif-portal opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@gbif-portal
Copy link

Literature export gives an empty file

This issue was originally reported on helpdesk. There should be more than 5000 citations in the TSV but https://api.gbif.org/v1/literature/export?format=TSV&gbifDatasetKey=821cc27a-e3bb-4bc5-ac34-89ada245069d only give a header with no record.


Github user: @ManonGros
User: See in registry - Send email
System: Safari 18.1.1 / Mac OS X 10.15.7
Referer: https://www.gbif.org/resource/search?contentType=literature&gbifDatasetKey=821cc27a-e3bb-4bc5-ac34-89ada245069d
Window size: width 1728 - height 926
API log
Site log
System health at time of feedback: OPERATIONAL

@gbif-portal gbif-portal added the bug Something isn't working label Nov 27, 2024
@ManonGros
Copy link

Possibly related to gbif/portal-feedback#5579?

@mike-podolskiy90 mike-podolskiy90 transferred this issue from gbif/portal-feedback Dec 10, 2024
@mike-podolskiy90
Copy link
Collaborator

@ahakanzn there are two issues about empty exports, please have a look when you have time

@ahakanzn ahakanzn self-assigned this Dec 10, 2024
@ahakanzn
Copy link
Collaborator

Issue is fixed and deployed to prod

@MattBlissett
Copy link
Member

I think this needs a better fix, at least for the K8S (now master) branch.

Currently it returns HTTP 200 OK if it fails:

10.x.x.x 3998253 - [10/Dec/2024:09:02:21 +0000] "GET http://api.gbif.org/v1/literature/export?format=TSV&gbifDatasetKey=821cc27a-e3bb-4bc5-ac34-89ada245069d HTTP/2.0" 200 0 pass_uncacheable 'https://github.com/gbif/literature-ws/issues/48' 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36'

It should return 500 if there's a failure, which will make it easier to monitor and informs the user that something was wrong.

@MattBlissett MattBlissett reopened this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants