Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vocabularies for searches of GRSciColl collections and institutions #289

Open
ManonGros opened this issue May 15, 2024 · 3 comments
Open

Comments

@ManonGros
Copy link
Collaborator

Relates to gbif/registry#549 and gbif/registry-console#558.

The drop download lists should reflect the available vocabularies. For example this drop down list should use https://registry.gbif.org/vocabulary/CollectionContentType/concepts:
Screenshot 2024-05-15 at 15 13 16

@ManonGros
Copy link
Collaborator Author

As for the registry console, could we display the parent concepts along with the children concepts?

@MortenHofft
Copy link
Member

MortenHofft commented May 24, 2024

In the registry I have to do 42 requests for a single keystroke on e.g. PreservationType
It isn't really something I want to do in a public facing product that should perform well. For that we probably need a backend that supports that kind of functionality.

ping @marcos-lg
Currently I can do https://api.gbif.org/v1/vocabularies/PreservationType/concepts/suggest?q=sto&locale=en-AR

that will return

[
  {
    "key": 1106,
    "name": "StorageOutdoors",
    "labels": []
  },
...
]

getting the label with fallback to english, as well as all the parent labels would make it more usable. Currently I would have to do an extra lookup for each result without a label, and secondly an additional lookup for each parent. And do so for all results. And so we end up with many requests per keystroke

@marcos-lg
Copy link

It's fine to me to add English labels and parents in the response. Can you create an issue in the vocabulary repo with it and any other wishes you might have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants