Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button for occurrence popover has changed locations #909

Open
mpitblado opened this issue Jan 30, 2025 · 1 comment
Open

Close button for occurrence popover has changed locations #909

mpitblado opened this issue Jan 30, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@mpitblado
Copy link

While technically this is a divergence between the current hosted portals and the new, I accept that it is a matter of opinion.

Current hosted portals

Users of the current portals have the close button for the occurrence popover in the top left of the interface. This would be intuitive for Mac users, who are accustomed to close on the top left hand corner. For windows users, it is a horizontal flip, but understandable due to the scroll bar and direction of the popover.

Image

UAT

The close button for the popover has moved to the bottom left. I am not sure if this is the default that came with the component library, but I don't believe that many users will have experienced this in other applications. I had to look around for a few seconds to find it. Additionally, there is nothing in the top of the interface that would prevent the button from returning to the top left.

Image

@MortenHofft
Copy link
Member

Thanks for caring enough to leave the issue!
i imagine that most users will close it either by esc or clicking outside the drawer. And bottomis more comvinenet on mobile.

But that said. You are right that it could also go to the top left on desktop. And that might indeed be more intuitive.

I'm not going to consider this a regression though

@MortenHofft MortenHofft added the enhancement New feature or request label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants