New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed form returns as successful #856

Open

MortenHofft opened this issue Jan 22, 2025 · 0 comments

Labels

GBIF.org parity

Member

MortenHofft commented Jan 22, 2025

gbif-web/packages/graphql-api/src/api-utils/forms/hosted-portal-application/index.ts

Line 98 in 9d08bc8

res.status(200).json({ message: 'From submitted succesfully' });

If fail then return statusvcode 200 and a success message.
That seems wrong.

Secondly the success message has a spelling mistake (from instead of form). And we should ensure that these are translatable.

MortenHofft added the GBIF.org parity label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment