Skip to content

Commit 779aa78

Browse files
colin-pmJoshuaWatt
authored andcommitted
Add maintainers for products
Adds the ability to specify one or more maintainers for each product. This commit adds support for the object in the schema, documents it in whisk.example.yaml, and adds a test to ensure it is working. Signed-off-by: Colin McAllister <[email protected]>
1 parent 9916c0b commit 779aa78

File tree

3 files changed

+64
-0
lines changed

3 files changed

+64
-0
lines changed

ci/test.py

+40
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,46 @@ def test_env_var_expansion(self):
246246
success=False,
247247
)
248248

249+
def test_maintainers(self):
250+
self.write_conf(
251+
"""
252+
version: 2
253+
defaults:
254+
products:
255+
- test-dunfell
256+
mode: mode
257+
site: site
258+
259+
versions:
260+
dunfell:
261+
oeinit: {ROOT}/ci/dummy-init
262+
263+
products:
264+
test-dunfell:
265+
maintainers:
266+
- name: John Doe
267+
268+
- name: Jane Doe
269+
270+
default_version: dunfell
271+
272+
modes:
273+
mode: {{}}
274+
275+
sites:
276+
site: {{}}
277+
278+
""".format(
279+
ROOT=ROOT
280+
)
281+
)
282+
283+
self.assertShellCode(
284+
"""\
285+
. init-build-env
286+
"""
287+
)
288+
249289
def test_tags(self):
250290
self.write_conf(
251291
"""\

whisk.example.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,12 @@ products:
217217
# particularly if you use a lot of codenames (optional)
218218
description: A test qemux86-64 product
219219

220+
# The list of maintainers for the product. The name of the maintainer is
221+
# required, but the email is optional.
222+
maintainers:
223+
- name: John Doe
224+
225+
220226
# The default version that this product will build with if unspecified, or
221227
# if the user specifies the default should be used. The user can force a
222228
# product to use a different version if they are feeling adventurous

whisk.schema.json

+18
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,24 @@
222222
"description": {
223223
"type": "string"
224224
},
225+
"maintainers": {
226+
"type": "array",
227+
"items": {
228+
"type": "object",
229+
"properties": {
230+
"name": {
231+
"type": "string"
232+
},
233+
"email": {
234+
"type": "string"
235+
}
236+
}
237+
},
238+
"additionalProperties": false,
239+
"required": [
240+
"name"
241+
]
242+
},
225243
"default_version": {
226244
"type": "string"
227245
},

0 commit comments

Comments
 (0)