Use plain boolean checks instead of Assert in tests (#69)

Co-authored-by: Codex <codex@openai.com>

Author: fingolfin

tst/git.tst

@@ -5,14 +5,14 @@ gap> tmpdir := Filename( DirectoryTemporary(), "packagemaker-git-tst" );;
 gap> if IsDirectoryPath( tmpdir ) then RemoveDirectoryRecursively( tmpdir ); fi;
 gap> AUTODOC_CreateDirIfMissing( tmpdir );
 true
-gap> Assert( 0,
->   PKGMKR_CommandOutput( Directory( tmpdir ), "git", [ "init", "-b", "main" ] ) <> fail );;
-gap> Assert( 0,
->   PKGMKR_CommandOutput( Directory( tmpdir ), "git",
->                         [ "config", "user.name", "PackageMaker Tests" ] ) <> fail );;
-gap> Assert( 0,
->   PKGMKR_CommandOutput( Directory( tmpdir ), "git",
->                         [ "config", "user.email", "tests@example.invalid" ] ) <> fail );;
+gap> PKGMKR_CommandOutput( Directory( tmpdir ), "git", [ "init", "-b", "main" ] ) <> fail;
+true
+gap> PKGMKR_CommandOutput( Directory( tmpdir ), "git",
+>                         [ "config", "user.name", "PackageMaker Tests" ] ) <> fail;
+true
+gap> PKGMKR_CommandOutput( Directory( tmpdir ), "git",
+>                         [ "config", "user.email", "tests@example.invalid" ] ) <> fail;
+true
 gap> PrintTo( Filename( Directory( tmpdir ), "README.md" ), "probe\n" );;
 gap> CreateGitRepository(
 >   Directory( tmpdir ),
@@ -68,14 +68,14 @@ gap> tmpdir := Filename( DirectoryTemporary(), "packagemaker-git-retry-tst" );;
 gap> if IsDirectoryPath( tmpdir ) then RemoveDirectoryRecursively( tmpdir ); fi;
 gap> AUTODOC_CreateDirIfMissing( tmpdir );
 true
-gap> Assert( 0,
->   PKGMKR_CommandOutput( Directory( tmpdir ), "git", [ "init", "-b", "main" ] ) <> fail );;
-gap> Assert( 0,
->   PKGMKR_CommandOutput( Directory( tmpdir ), "git",
->                         [ "config", "user.name", "PackageMaker Tests" ] ) <> fail );;
-gap> Assert( 0,
->   PKGMKR_CommandOutput( Directory( tmpdir ), "git",
->                         [ "config", "user.email", "tests@example.invalid" ] ) <> fail );;
+gap> PKGMKR_CommandOutput( Directory( tmpdir ), "git", [ "init", "-b", "main" ] ) <> fail;
+true
+gap> PKGMKR_CommandOutput( Directory( tmpdir ), "git",
+>                         [ "config", "user.name", "PackageMaker Tests" ] ) <> fail;
+true
+gap> PKGMKR_CommandOutput( Directory( tmpdir ), "git",
+>                         [ "config", "user.email", "tests@example.invalid" ] ) <> fail;
+true
 gap> PrintTo( Filename( Directory( tmpdir ), "README.md" ), "probe\n" );;
 gap> attempt := 0;;
 gap> CreateGitRepository(

tst/template.tst

@@ -17,29 +17,29 @@ gap> ChangeDirectoryCurrent( tmpdir );;
 gap> AUTODOC_CreateDirIfMissing( pkginfo.PackageName );
 true
 gap> TranslateTemplate( fail, "README.md", pkginfo );;
-gap> Assert( 0,
->   PositionSublist( StringFile( Filename( Directory( pkginfo.PackageName ), "README.md" ) ),
->                    "# The GAP package DemoPackage" ) = 1 );;
+gap> PositionSublist( StringFile( Filename( Directory( pkginfo.PackageName ), "README.md" ) ),
+>                    "# The GAP package DemoPackage" ) = 1;
+true
 gap> AUTODOC_CreateDirIfMissing( Concatenation( pkginfo.PackageName, "/gap" ) );
 true
 gap> TranslateTemplate( "gap/PKG.gd",
 >                      Concatenation( "gap/", pkginfo.PackageName, ".gd" ),
 >                      pkginfo );;
-gap> Assert( 0,
->   PositionSublist(
+gap> PositionSublist(
 >     StringFile( Filename( Directory( Concatenation( pkginfo.PackageName, "/gap" ) ),
 >                           Concatenation( pkginfo.PackageName, ".gd" ) ) ),
->     "DeclareGlobalFunction( \"DemoPackage_Example\" );" ) <> fail );;
+>     "DeclareGlobalFunction( \"DemoPackage_Example\" );" ) <> fail;
+true
 gap> AUTODOC_CreateDirIfMissing( Concatenation( pkginfo.PackageName, "/.github" ) );
 true
 gap> AUTODOC_CreateDirIfMissing( Concatenation( pkginfo.PackageName, "/.github/workflows" ) );
 true
 gap> CopyTemplate( fail, ".github/workflows/CI.yml", pkginfo );;
-gap> Assert( 0,
->   StringFile( Filename( Directory( Concatenation( pkginfo.PackageName, "/.github/workflows" ) ),
+gap> StringFile( Filename( Directory( Concatenation( pkginfo.PackageName, "/.github/workflows" ) ),
 >                         "CI.yml" ) ) =
 >   StringFile( Filename( DirectoriesPackageLibrary( "PackageMaker", "templates" )[1],
->                         ".github/workflows/CI.yml" ) ) );;
+>                         ".github/workflows/CI.yml" ) );
+true
 gap> ChangeDirectoryCurrent( olddir );;
 gap> RemoveDirectoryRecursively( tmpdir );;