Switched to tagMightHaveEitherTypeOrNamePosition

Author: kraenhansen

src/getDefaultTagStructureForMode.js

@@ -470,11 +470,6 @@ const getDefaultTagStructureForMode = (mode) => {
         [
           'typeOrNameRequired', true,
         ],
-
-        // "type"
-        [
-          'typeAllowed', true,
-        ],
       ]),
     ],
 
@@ -490,11 +485,6 @@ const getDefaultTagStructureForMode = (mode) => {
         [
           'typeOrNameRequired', true,
         ],
-
-        // "type"
-        [
-          'typeAllowed', true,
-        ],
       ]),
     ],
 
@@ -510,11 +500,6 @@ const getDefaultTagStructureForMode = (mode) => {
         [
           'typeOrNameRequired', true,
         ],
-
-        // "type"
-        [
-          'typeAllowed', true,
-        ],
       ]),
     ],
 

src/iterateJsdoc.js

@@ -769,6 +769,7 @@ const getUtils = (
   for (const method of [
     'tagMightHaveNamePosition',
     'tagMightHaveTypePosition',
+    'tagMightHaveEitherTypeOrNamePosition',
   ]) {
     utils[method] = (tagName, otherModeMaps) => {
       const result = jsdocUtils[method](tagName);

src/jsdocUtils.js

@@ -1274,6 +1274,7 @@ export default {
   parseClosureTemplateTag,
   pathDoesNotBeginWith,
   setTagStructure,
+  tagMightHaveEitherTypeOrNamePosition,
   tagMightHaveNamepath,
   tagMightHaveNamePosition,
   tagMightHaveTypePosition,

src/rules/noUndefinedTypes.js

@@ -189,11 +189,11 @@ export default iterateJsdoc(({
   const jsdocTagsWithPossibleType = utils.filterTags(({
     tag,
   }) => {
-    return utils.tagMightHaveTypePosition(tag) && (tag !== 'suppress' || settings.mode !== 'closure');
+    return utils.tagMightHaveEitherTypeOrNamePosition(tag) && (tag !== 'suppress' || settings.mode !== 'closure');
   });
 
   for (const tag of jsdocTagsWithPossibleType) {
-    const possibleType = tag.type || tag.namepathOrURL;
+    const possibleType = tag.type || tag.name || tag.namepathOrURL;
 
     let parsedType;
 

test/rules/assertions/noUndefinedTypes.js

@@ -387,6 +387,10 @@ export default {
        */
       `,
       errors: [
+        {
+          line: 3,
+          message: 'The type \'SomeType\' is undefined.',
+        },
         {
           line: 6,
           message: 'The type \'SomeType\' is undefined.',
@@ -412,6 +416,10 @@ export default {
        */
       `,
       errors: [
+        {
+          line: 3,
+          message: 'The type \'SomeType\' is undefined.',
+        },
         {
           line: 6,
           message: 'The type \'SomeType\' is undefined.',