-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor of aal.c #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MkeyBeez
wants to merge
79
commits into
g0d:main
Choose a base branch
from
MkeyBeez:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Implements addition, subtraction, multipilcation, division, and modulo operations.
We cast everything to a struct BigFloat to unify common operations needed for string arithmetic.
Multiplication for numbers longer than 32 digits uses recursive karatsuba, one can of couse tune the amount of digits to specify exactly when this kicks in; I have not done extensive benchmarks yet.
The easiest way to try out the proposed implementation is to open the attached
colab.ipynbin a google colab instance and execute the notebook. You can then try the operations interactively.Implementation of Square roots should be easy with an iterative algorithm, Implementing string exponentiation is a bit more tricky since this requires logarithm operations in non integer cases. Let me know what you think.