Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription groups should show the platform icon by creator icon #1584

Open
VoxelPrismatic opened this issue Dec 9, 2024 · 2 comments
Open
Labels
Core Enhancement New feature or request UI/UX

Comments

@VoxelPrismatic
Copy link

Use Cases

  1. Patreon group
    Screenshot_20241209-140816

  2. Any other group where one channel gets exclusive content, but you are subscribed to both anyway

  3. Adding subscriptions to a group, but the Patreon plugin is broken and crashes the app whenever you load a Patreon creator's feed

Proposal

Either switch to the [Creators] tab listing style, or overlay the platform icon over the creator icon.

References

(I am aware this is a duplicate, but I've already done some preliminary research to help move this process along)

@Zvonimir-FUTO Zvonimir-FUTO added Enhancement New feature or request UI/UX Core labels Dec 9, 2024
@VoxelPrismatic
Copy link
Author

Preliminary search

The platform icon code below, taken from the playlist listing model, should be placed in the Subscription Bar (which I believe also provides the subscriptions group grid)

<com.futo.platformplayer.views.platform.PlatformIndicator
    android:id="@+id/thumbnail_platform"
    android:layout_width="20dp"
    android:layout_height="20dp"
    android:layout_gravity="bottom|end"
    android:layout_marginStart="4dp"
    android:layout_marginBottom="4dp" />

Here, I modified it to use the bottom-right corner instead of the bottom-left.

I am not in the position to build android apps, so I cannot create a pull request. But I hope my preliminary search helps speed up the process.

@VoxelPrismatic
Copy link
Author

It looks like something along the lines of the following needs to be added to CreatorBarViewHolder.kt to support the new image:

import com.futo.platformplayer.views.platform.PlatformIndicator

// ...

class CreatorBarViewHolder(...) ... {
    // ...

    private val _platformIndicator: PlatformIndicator;

    // ...
    init {
        _platformIndicator = _view.findViewById(R.id.thumbnail_platform);
        // ...
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Enhancement New feature or request UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants