Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting under a comment crashes the app #1583

Closed
1 of 3 tasks
VoxelPrismatic opened this issue Dec 9, 2024 · 4 comments
Closed
1 of 3 tasks

Commenting under a comment crashes the app #1583

VoxelPrismatic opened this issue Dec 9, 2024 · 4 comments
Labels
Bug Something isn't working Core Crash Reproducible Solved Issue/feature has been fixed/implemented in development branch but not yet pushed to end users

Comments

@VoxelPrismatic
Copy link

What happened?

  1. Find a comment
  2. Comment under that comment
  3. *crash*
screen-20241209-140204.mp4

Grayjay Version

268

What plugins are you seeing the problem on?

Youtube

Plugin Version

218

When do you experience the issue?

  • While logged in
  • While logged out
  • N/A

Relevant log output

Version information (version_name = 268, version_code = 268, flavor = stable, build_type = release)
Device information (brand= Sony, manufacturer = Sony, device = XQ-DQ62, version-sdk = 34, version-os = )

(e, ExceptionActivity, 2024-12-09 20:03:12): Uncaught exception ("Unknown Context"): Index -1 out of bounds for length 2

java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 2
	at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
	at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
	at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
	at java.util.Objects.checkIndex(Objects.java:359)
	at java.util.ArrayList.set(ArrayList.java:477)
	at com.futo.platformplayer.views.segments.CommentsList.replaceComment(CommentsList.kt:271)
	at com.futo.platformplayer.fragment.mainactivity.main.VideoDetailView$62$2.invoke(VideoDetailView.kt:736)
	at com.futo.platformplayer.fragment.mainactivity.main.VideoDetailView$62$2.invoke(VideoDetailView.kt:731)
	at com.futo.platformplayer.views.overlays.RepliesOverlay$1.invoke(RepliesOverlay.kt:75)
	at com.futo.platformplayer.views.overlays.RepliesOverlay$1.invoke(RepliesOverlay.kt:73)
	at com.futo.platformplayer.constructs.Event1.emit(Event.kt:99)
	at com.futo.platformplayer.views.comments.AddCommentView$1$1$1.invoke(AddCommentView.kt:36)
	at com.futo.platformplayer.views.comments.AddCommentView$1$1$1.invoke(AddCommentView.kt:36)
	at com.futo.platformplayer.UIDialogs$Companion$showCommentDialog$2.invoke(UIDialogs.kt:503)
	at com.futo.platformplayer.UIDialogs$Companion$showCommentDialog$2.invoke(UIDialogs.kt:503)
	at com.futo.platformplayer.constructs.Event1.emit(Event.kt:99)
	at com.futo.platformplayer.dialogs.CommentDialog.onCreate$lambda$1(CommentDialog.kt:114)
	at com.futo.platformplayer.dialogs.CommentDialog.$r8$lambda$Ch6uELb6tLO7Kybqhlib27OXS-I(Unknown Source:0)
	at com.futo.platformplayer.dialogs.CommentDialog$$ExternalSyntheticLambda1.onClick(D8$$SyntheticClass:0)
	at android.view.View.performClick(View.java:7670)
	at android.view.View.performClickInternal(View.java:7644)
	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
	at android.view.View$PerformClick.run(View.java:30175)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:205)
	at android.os.Looper.loop(Looper.java:294)
	at android.app.ActivityThread.main(ActivityThread.java:8223)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:977)
@Zvonimir-FUTO
Copy link
Collaborator

Thank you for reporting, we are investigating this.

@VoxelPrismatic
Copy link
Author

I forgot to add that the comment does actually post, so it may be a rendering issue.

@Zvonimir-FUTO Zvonimir-FUTO added the Solved Issue/feature has been fixed/implemented in development branch but not yet pushed to end users label Dec 10, 2024
@Zvonimir-FUTO
Copy link
Collaborator

The fix will be released in the next version of Grayjay.

@Zvonimir-FUTO
Copy link
Collaborator

This has been fixed in v276.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Crash Reproducible Solved Issue/feature has been fixed/implemented in development branch but not yet pushed to end users
Projects
None yet
Development

No branches or pull requests

2 participants