refactor: analysis

Author: Gordon Hayes

section_4/login_example_sequence_animation/analysis_options.yaml

@@ -1 +1,10 @@
-include: package:pedantic/analysis_options.yaml
+include: package:very_good_analysis/analysis_options.yaml
+
+analyzer:
+  strong-mode:
+    implicit-casts: false
+    implicit-dynamic: false
+
+linter:
+  rules:
+    public_member_api_docs: false

section_4/login_example_sequence_animation/lib/main.dart

@@ -2,16 +2,18 @@ import 'package:flutter/material.dart';
 
 import 'pages/auth_page.dart';
 
-void main() => runApp(MyApp());
+void main() => runApp(const MyApp());
 
 class MyApp extends StatelessWidget {
+  const MyApp({Key key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
-    return MaterialApp(
+    return const MaterialApp(
       debugShowCheckedModeBanner: false,
       title: 'Sequence Animation App',
       home: Scaffold(
-        body: const AuthPage(),
+        body: AuthPage(),
       ),
     );
   }

section_4/login_example_sequence_animation/lib/pages/auth_page.dart

@@ -49,7 +49,7 @@ class _AuthPageState extends State<AuthPage>
   void initState() {
     _controller = AnimationController(
       vsync: this,
-      duration: Duration(milliseconds: 1200),
+      duration: const Duration(milliseconds: 1200),
     )..addStatusListener(_animationStatusListener);
 
     _initSequenceAnimation();
@@ -176,7 +176,10 @@ class _AuthPageState extends State<AuthPage>
 
   Future<void> _routeTransition() {
     return Future.delayed(const Duration(milliseconds: 500), () {
-      Navigator.pushReplacement(context, FadeRoute(HomePage()));
+      Navigator.pushReplacement<dynamic, dynamic>(
+        context,
+        FadeRoute(const HomePage()),
+      );
     });
   }
 
@@ -188,8 +191,8 @@ class _AuthPageState extends State<AuthPage>
         children: <Widget>[
           ConstrainedBox(
             constraints: const BoxConstraints.expand(),
-            child: FlutterLogo(
-              colors: Colors.blueGrey,
+            child: const FlutterLogo(
+              textColor: Colors.blueGrey,
               style: FlutterLogoStyle.markOnly,
             ),
           ),
@@ -203,20 +206,23 @@ class _AuthPageState extends State<AuthPage>
                   child: BackdropFilter(
                     filter: ImageFilter.blur(sigmaX: 10.0, sigmaY: 10.0),
                     child: Container(
-                      height: _sequenceAnimation['height'].value,
-                      width: _sequenceAnimation['width'].value,
+                      height: _sequenceAnimation['height'].value as double,
+                      width: _sequenceAnimation['width'].value as double,
                       decoration: BoxDecoration(
                         color: Colors.grey.shade300.withOpacity(0.1),
-                        borderRadius: _sequenceAnimation['borderRadius'].value,
+                        borderRadius: _sequenceAnimation['borderRadius'].value
+                            as BorderRadiusGeometry,
                       ),
                       child: Stack(
                         children: <Widget>[
                           Center(
                             child: body,
                           ),
                           Header(
-                              scale: _sequenceAnimation['scale'].value,
-                              height: _sequenceAnimation['headerHight'].value,
+                              scale:
+                                  _sequenceAnimation['scale'].value as double,
+                              height: _sequenceAnimation['headerHight'].value
+                                  as double,
                               isLogin: _isLogin),
                         ],
                       ),

section_4/login_example_sequence_animation/lib/pages/home_page.dart

@@ -3,7 +3,7 @@ import 'package:flutter/material.dart';
 import '../styles/backgrounds.dart';
 
 class HomePage extends StatefulWidget {
-  HomePage({Key key}) : super(key: key);
+  const HomePage({Key key}) : super(key: key);
 
   @override
   _HomePageState createState() => _HomePageState();

section_4/login_example_sequence_animation/lib/styles/backgrounds.dart

@@ -7,7 +7,7 @@ BoxDecoration backgroundAuthDecoration() {
     gradient: LinearGradient(
       begin: Alignment.bottomLeft,
       end: Alignment.topRight,
-      stops: [0.1, 0.5, 0.9],
+      stops: const [0.1, 0.5, 0.9],
       colors: [
         authPageBackgroundColor[700],
         authPageBackgroundColor[600],
@@ -25,7 +25,7 @@ LinearGradient linearGradientHomeDecoration() {
   return LinearGradient(
     begin: Alignment.bottomLeft,
     end: Alignment.topRight,
-    stops: [0.1, 0.5, 0.7, 0.9],
+    stops: const [0.1, 0.5, 0.7, 0.9],
     colors: [
       homePageBackgroundColor[800],
       homePageBackgroundColor[700],

section_4/login_example_sequence_animation/lib/utils/fade_route.dart

@@ -1,10 +1,10 @@
 import 'package:flutter/widgets.dart';
 
-class FadeRoute extends PageRoute {
-  final Widget child;
-
+class FadeRoute extends PageRoute<dynamic> {
   FadeRoute(this.child);
 
+  final Widget child;
+
   @override
   Color get barrierColor => null;
 

section_4/login_example_sequence_animation/lib/widgets/expanding_page_animation.dart

@@ -21,7 +21,7 @@ class ExpandingPageAnimation extends StatelessWidget {
   Widget build(BuildContext context) {
     return Center(
       child: AnimatedContainer(
-        duration: Duration(milliseconds: 500),
+        duration: const Duration(milliseconds: 500),
         curve: Curves.ease,
         width: _width,
         height: _height,

section_4/login_example_sequence_animation/lib/widgets/forms/call_to_action_button.dart

@@ -15,7 +15,7 @@ class CallToActionButton extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return FlatButton(
+    return TextButton(
       onPressed: () {
         if (onPressed != null) {
           onPressed();

section_4/login_example_sequence_animation/lib/widgets/forms/login_form.dart

@@ -24,39 +24,37 @@ class LoginForm extends StatelessWidget {
       child: SingleChildScrollView(
         child: Padding(
           padding: EdgeInsets.only(top: safeArea),
-          child: Container(
-            child: Column(
-              children: <Widget>[
-                Padding(
-                    padding: const EdgeInsets.only(bottom: 16.0),
-                    child: CallToActionText('Please sign in to continue')),
-                TextInputBox(
-                  icon: Icons.email,
-                  hintText: 'Email',
-                ),
-                TextInputBox(
-                  icon: Icons.lock_outline,
-                  hintText: 'Password',
-                  obscureText: true,
-                ),
-                CallToActionButton(
-                  onPressed: onLoginPressed,
-                  text: 'Login',
-                  color: headerLoginColor,
-                ),
-                Row(
-                  mainAxisAlignment: MainAxisAlignment.center,
-                  children: <Widget>[
-                    CallToActionText("Don't have an account?"),
-                    CallToActionButton(
-                      onPressed: onSignUpPressed,
-                      text: 'Sign Up',
-                      color: headerSignUpColor,
-                    ),
-                  ],
-                ),
-              ],
-            ),
+          child: Column(
+            children: <Widget>[
+              const Padding(
+                  padding: EdgeInsets.only(bottom: 16.0),
+                  child: CallToActionText('Please sign in to continue')),
+              const TextInputBox(
+                icon: Icons.email,
+                hintText: 'Email',
+              ),
+              const TextInputBox(
+                icon: Icons.lock_outline,
+                hintText: 'Password',
+                obscureText: true,
+              ),
+              CallToActionButton(
+                onPressed: onLoginPressed,
+                text: 'Login',
+                color: headerLoginColor,
+              ),
+              Row(
+                mainAxisAlignment: MainAxisAlignment.center,
+                children: <Widget>[
+                  const CallToActionText("Don't have an account?"),
+                  CallToActionButton(
+                    onPressed: onSignUpPressed,
+                    text: 'Sign Up',
+                    color: headerSignUpColor,
+                  ),
+                ],
+              ),
+            ],
           ),
         ),
       ),

section_4/login_example_sequence_animation/lib/widgets/forms/signup_form.dart

@@ -26,19 +26,19 @@ class SignUpForm extends StatelessWidget {
           padding: EdgeInsets.only(top: safeArea),
           child: Column(
             children: <Widget>[
-              Padding(
-                padding: const EdgeInsets.all(16.0),
+              const Padding(
+                padding: EdgeInsets.all(16.0),
                 child: CallToActionText('Create an account'),
               ),
-              TextInputBox(
+              const TextInputBox(
                 icon: Icons.portrait,
                 hintText: 'Name',
               ),
-              TextInputBox(
+              const TextInputBox(
                 icon: Icons.email,
                 hintText: 'Email',
               ),
-              TextInputBox(
+              const TextInputBox(
                 icon: Icons.lock_outline,
                 hintText: 'Password',
                 obscureText: true,
@@ -50,7 +50,7 @@ class SignUpForm extends StatelessWidget {
               Row(
                 mainAxisAlignment: MainAxisAlignment.center,
                 children: <Widget>[
-                  CallToActionText('Already have an account?'),
+                  const CallToActionText('Already have an account?'),
                   CallToActionButton(
                     text: 'Sign in',
                     onPressed: onLoginPressed,

section_4/login_example_sequence_animation/lib/widgets/forms/text_input_box.dart

@@ -18,19 +18,19 @@ class TextInputBox extends StatelessWidget {
       padding: const EdgeInsets.all(8.0),
       child: TextFormField(
         obscureText: obscureText,
-        style: TextStyle(color: Colors.white),
+        style: const TextStyle(color: Colors.white),
         decoration: InputDecoration(
           prefixIcon: Icon(icon, color: Colors.white54),
           focusedBorder: OutlineInputBorder(
             borderRadius: BorderRadius.circular(30),
-            borderSide: BorderSide(color: Colors.white, width: 2.0),
+            borderSide: const BorderSide(color: Colors.white, width: 2.0),
           ),
           enabledBorder: OutlineInputBorder(
             borderRadius: BorderRadius.circular(30),
-            borderSide: BorderSide(color: Colors.white54, width: 2.0),
+            borderSide: const BorderSide(color: Colors.white54, width: 2.0),
           ),
           hintText: hintText,
-          hintStyle: TextStyle(color: Colors.white70),
+          hintStyle: const TextStyle(color: Colors.white70),
         ),
       ),
     );