Skip to content

Commit bb57110

Browse files
committed
Merge remote-tracking branch 'origin/master' into android-configure-via-json
2 parents 7434da2 + e754101 commit bb57110

11 files changed

+48
-15
lines changed

ios/Firestack.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@
244244
58B511F01A9E6C8500147676 /* Debug */ = {
245245
isa = XCBuildConfiguration;
246246
buildSettings = {
247+
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
247248
DEFINES_MODULE = NO;
248249
EMBEDDED_CONTENT_CONTAINS_SWIFT = NO;
249250
ENABLE_BITCODE = YES;
@@ -272,6 +273,7 @@
272273
58B511F11A9E6C8500147676 /* Release */ = {
273274
isa = XCBuildConfiguration;
274275
buildSettings = {
276+
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
275277
DEFINES_MODULE = NO;
276278
EMBEDDED_CONTENT_CONTAINS_SWIFT = NO;
277279
ENABLE_BITCODE = YES;

ios/Firestack/Firestack.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#import "Firestack.h"
88
#import "FirestackErrors.h"
99
#import "FirestackEvents.h"
10-
#import "FirestackAnalytics.h"
10+
// #import "FirestackAnalytics.h"
1111
// #import "FirestackCloudMessaging.h"
1212

1313
static Firestack *_sharedInstance = nil;

ios/Firestack/FirestackAnalytics.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#ifndef FirestackAnalytics_h
1010
#define FirestackAnalytics_h
1111

12-
#import "FirebaseAnalytics.h"
1312
#import "RCTBridgeModule.h"
1413

1514
@interface FirestackAnalytics : NSObject <RCTBridgeModule> {

ios/Firestack/FirestackAnalytics.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
#import "FirestackEvents.h"
1111
#import "FirestackAnalytics.h"
1212

13+
@import FirebaseAnalytics;
14+
1315
@implementation FirestackAnalytics
1416

1517
- (void)dealloc

ios/Firestack/FirestackCloudMessaging.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#define FirestackCloudMessaging_h
1111

1212
#import "Firebase.h"
13-
#import "FirebaseMessaging.h"
1413
#import "RCTEventEmitter.h"
1514
#import "RCTBridgeModule.h"
1615
#import "RCTUtils.h"

ios/Firestack/FirestackCloudMessaging.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#import "FirestackCloudMessaging.h"
1515
#import "FirestackEvents.h"
1616
#import "RCTConvert.h"
17-
#import "FirestackCloudMessaging.h"
1817

1918
// https://github.com/facebook/react-native/blob/master/Libraries/PushNotificationIOS/RCTPushNotificationManager.m
2019
@implementation RCTConvert (UILocalNotification)

ios/Firestack/FirestackDatabase.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#define FirestackDatabase_h
1111

1212
#import "Firebase.h"
13-
#import "FirebaseDatabase.h"
1413
#import "RCTEventEmitter.h"
1514
#import "RCTBridgeModule.h"
1615

ios/Firestack/FirestackDatabase.m

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,8 @@ @implementation FirestackDatabase
358358
NSDictionary *props =
359359
[self snapshotToDict:snapshot];
360360
[self
361-
sendJSEvent:eventName
361+
sendJSEvent:DATABASE_DATA_EVENT
362+
title:eventName
362363
props: @{
363364
@"eventName": eventName,
364365
@"path": path,
@@ -676,6 +677,7 @@ - (NSDictionary *) getAndSendDatabaseError:(NSError *) error
676677
};
677678
[self
678679
sendJSEvent:DATABASE_ERROR_EVENT
680+
title:DATABASE_ERROR_EVENT
679681
props: evt];
680682

681683
return evt;
@@ -686,11 +688,12 @@ - (NSDictionary *) getAndSendDatabaseError:(NSError *) error
686688
return @[DATABASE_DATA_EVENT, DATABASE_ERROR_EVENT];
687689
}
688690

689-
- (void) sendJSEvent:(NSString *)title
691+
- (void) sendJSEvent:(NSString *)type
692+
title:(NSString *)title
690693
props:(NSDictionary *)props
691694
{
692695
@try {
693-
[self sendEventWithName:DATABASE_DATA_EVENT
696+
[self sendEventWithName:type
694697
body:@{
695698
@"eventName": title,
696699
@"body": props

ios/Firestack/FirestackErrors.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
#import "RCTBridgeModule.h"
1313
#import "Firebase.h"
14-
#import "FirebaseAuth.h"
1514

1615
@interface FirestackErrors : NSObject <RCTBridgeModule> {
1716

ios/Firestack/FirestackStorage.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#define FirestackStorage_h
1111

1212
#import "Firebase.h"
13-
#import "FirebaseStorage.h"
1413
#import "RCTBridgeModule.h"
1514
#import "RCTEventEmitter.h"
1615

0 commit comments

Comments
 (0)