Skip to content

Commit 4032a71

Browse files
committed
Merge pull request #438 from dsyme/fix-regression
fix regression spotted in Microsoft\visualfsharp tests
2 parents 06128df + f788a16 commit 4032a71

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

RELEASE_NOTES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
#### 1.4.0.7 -
2+
* fix 410 - Symbols for C# fields (and especially enum fields)
3+
* Expose implemented abstract slots
4+
* Integrate with visualfsharp master
5+
16
#### 1.4.0.6 -
27
* fix 423 - Symbols for non-standard C# events
38
* fix 235 - XmlDocSigs for references assemblies

src/absil/illib.fs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1088,13 +1088,16 @@ module Shim =
10881088
let isInvalidPath(p:string) =
10891089
String.IsNullOrEmpty(p) || p.IndexOfAny(System.IO.Path.GetInvalidPathChars()) <> -1
10901090

1091+
let isInvalidFilename(p:string) =
1092+
String.IsNullOrEmpty(p) || p.IndexOfAny(System.IO.Path.GetInvalidFileNameChars()) <> -1
1093+
10911094
let isInvalidDirectory(d:string) =
10921095
d=null || d.IndexOfAny(Path.GetInvalidPathChars()) <> -1
10931096

10941097
isInvalidPath (path) ||
10951098
let directory = Path.GetDirectoryName(path)
10961099
let filename = Path.GetFileName(path)
1097-
isInvalidDirectory(directory) || isInvalidPath(filename)
1100+
isInvalidDirectory(directory) || isInvalidFilename(filename)
10981101

10991102
member __.GetTempPathShim() = System.IO.Path.GetTempPath()
11001103

0 commit comments

Comments
 (0)