require a click at /confirm, refer to /redeem

mxmehl · mxmehl · commit b469ea861c54 · 2022-03-14T13:10:23.000+01:00
diff --git a/fsfe_forms/app.py b/fsfe_forms/app.py
@@ -21,7 +21,7 @@
 
 from fsfe_forms import config
 from fsfe_forms.email import init_email
-from fsfe_forms.views import confirm, email, index
+from fsfe_forms.views import confirm, email, index, redeem
 
 
 # =============================================================================
@@ -84,5 +84,6 @@ def create_app():
     app.add_url_rule(rule="/", view_func=index)
     app.add_url_rule(rule="/email", view_func=email, methods=["GET", "POST"])
     app.add_url_rule(rule="/confirm", view_func=confirm)
+    app.add_url_rule(rule="/redeem", view_func=redeem)
 
     return app
diff --git a/fsfe_forms/templates/confirm.html b/fsfe_forms/templates/confirm.html
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<title>FSFE Form Server</title>
+<h1>FSFE Form Server</h1>
+<form action="/redeem" method="GET">
+  <input type="hidden" name="id" value="{{ id }}" />
+  <button type="submit">Confirm</button>
+</form>
diff --git a/fsfe_forms/views.py b/fsfe_forms/views.py
@@ -181,6 +181,13 @@ def email():
 
 @use_kwargs(confirm_parameters, location="query")
 def confirm(id):
+    """A landing page to confirm the ID via a click. Hands over to redeem()"""
+    return render_template("confirm.html", id=id)
+
+
+@use_kwargs(confirm_parameters, location="query")
+def redeem(id):
+    """Redeems an ID after checking its validity, refers to further actions then"""
     params = queue_pop(id)
 
     app_config = _find_app_config(params["appid"])
