Setup linting (#81)

* setup linting

* fixed linting

* fixed linting for py2

Author: roll

.travis.yml

@@ -19,8 +19,6 @@ install:
   - pip install coveralls
 
 script:
-  # FIXME: configure linter
-  # - make lint
   - make test
 
 after_success:

CONTRIBUTING.md

@@ -11,38 +11,33 @@ To install package and development dependencies into active environment:
 $ make install
 ```
 
-## Linting
+## Testing
 
-To lint the project codebase:
+To run tests with linting and coverage:
 
 ```
-$ make lint
+$ make test
 ```
 
-Under the hood `pylint` configured in `pylintrc` is used. On this stage it's already
+For linting `pylama` configured in `pylama.ini` is used. On this stage it's already
 installed into your environment and could be used separately with more fine-grained control
-as described in documentation - https://www.pylint.org/.
+as described in documentation - https://pylama.readthedocs.io/en/latest/.
 
-For example to check only errors:
+For example to sort results by error type:
 
 ```
-$ pylint -E <path>
+$ pylama --sort <path>
 ```
 
-## Testing
-
-To run tests with coverage:
-
-```
-$ make test
-```
-Under the hood `tox` powered by `py.test` and `coverage` configured in `tox.ini` is used.
-It's already installed into your environment and could be used separately with more fine-grained control
-as described in documentation - https://testrun.org/tox/latest/.
+For testing `tox` configured in `tox.ini` is used.
+It's already installed into your environment and could be used separately with more fine-grained control as described in documentation - https://testrun.org/tox/latest/.
 
 For example to check subset of tests against Python 2 environment with increased verbosity.
 All positional arguments and options after `--` will be passed to `py.test`:
 
 ```
 tox -e py27 -- -v tests/<path>
 ```
+
+Under the hood `tox` uses `pytest` configured in `pytest.ini`, `coverage`
+and `mock` packages. This packages are available only in tox envionments.

MANIFEST.in

@@ -1,7 +1,8 @@
 global-include VERSION
 include LICENSE.md
 include Makefile
-include pylintrc
+include pylama.ini
+include pytest.ini
 include README.md
 include tox.ini
 

Makefile

@@ -1,4 +1,4 @@
-.PHONY: all install list lint release test version
+.PHONY: all install list release test version
 
 
 PACKAGE := $(shell grep '^PACKAGE =' setup.py | cut -d "'" -f2)
@@ -14,14 +14,14 @@ list:
 	@grep '^\.PHONY' Makefile | cut -d' ' -f2- | tr ' ' '\n'
 
 lint:
-	pylint $(PACKAGE)
 
 release:
 	bash -c '[[ -z `git status -s` ]]'
 	git tag -a -m release $(VERSION)
 	git push --tags
 
 test:
+	pylama $(PACKAGE)
 	tox
 
 version:

jsontableschema/constraints/maximum.py

@@ -4,8 +4,6 @@
 from __future__ import print_function
 from __future__ import unicode_literals
 
-from datetime import datetime, date, time
-from dateutil.parser import parse as date_parse
 from .. import exceptions
 
 

jsontableschema/constraints/minimum.py

@@ -4,8 +4,6 @@
 from __future__ import print_function
 from __future__ import unicode_literals
 
-from datetime import datetime, date, time
-from dateutil.parser import parse as date_parse
 from .. import exceptions
 
 

jsontableschema/infer.py

@@ -137,15 +137,14 @@ def get(self, results):
                 else:
                     counts[result] = 1
 
-            # tuple representation of `counts` dict, sorted by values of `counts`
+            # tuple representation of `counts` dict sorted by values
             sorted_counts = sorted(counts.items(), key=operator.itemgetter(1),
                                    reverse=True)
             rv = {
                 'type': sorted_counts[0][0][0],
                 'format': sorted_counts[0][0][1]
             }
 
-
         return rv
 
 

jsontableschema/types/base.py

@@ -4,16 +4,18 @@
 from __future__ import print_function
 from __future__ import unicode_literals
 
+import six
+from six import add_metaclass
 from functools import partial
 from abc import ABCMeta, abstractmethod
-import six
 from .. import compat
 from .. import exceptions
 from .. import constraints
 
 
 # Module API
 
+@add_metaclass(ABCMeta)
 class JTSType(object):
     """Base class for all JSON Table Schema types.
 
@@ -96,7 +98,8 @@ def cast(self, value, skip_constraints=False):
             # Check required constraint
             if not skip_constraints:
                 required = self.__constraints.get('required', False)
-                constraints.check_required(self.__field_name, value, required,
+                constraints.check_required(
+                    self.__field_name, value, required,
                     self.null_values+[None])
 
             return None

jsontableschema/types/geojson.py

@@ -40,16 +40,16 @@ def cast_default(self, value, fmt=None):
             try:
                 jsonschema.validate(value, _geojson_schema)
                 return value
-            except jsonschema.exceptions.ValidationError as e:
+            except jsonschema.exceptions.ValidationError:
                 raise_with_traceback(exceptions.InvalidGeoJSONType())
         if isinstance(value, compat.str):
             try:
                 geojson = json.loads(value)
                 jsonschema.validate(geojson, _geojson_schema)
                 return geojson
-            except (TypeError, ValueError) as e:
+            except (TypeError, ValueError):
                 raise_with_traceback(exceptions.InvalidGeoJSONType())
-            except jsonschema.exceptions.ValidationError as e:
+            except jsonschema.exceptions.ValidationError:
                 raise_with_traceback(exceptions.InvalidGeoJSONType())
 
     def cast_topojson(self, value, fmt=None):

jsontableschema/types/number.py

@@ -32,7 +32,8 @@ class NumberType(base.JTSType):
     ]
     # ---
     python_type = decimal.Decimal
-    # TODO: Change this initialization to something more performant (http://bit.ly/1qgkK7B)
+    # We could change this initialization to something
+    # more performant (http://bit.ly/1qgkK7B)
     currencies = u''.join(compat.chr(i) for i
                           in range(0xffff)
                           if unicodedata.category(compat.chr(i)) == 'Sc')
@@ -41,7 +42,7 @@ def __preprocess_value(self, value):
         if type(value) is six.text_type:
             group_char = self.field.get('groupChar', ',')
             decimal_char = self.field.get('decimalChar', '.')
-            percent_char = '%‰‱％﹪٪';
+            percent_char = '%‰‱％﹪٪'
             value = value.replace(group_char, '').replace(decimal_char, '.')
             value = re.sub('['+percent_char+']', '', value)
         return value

jsontableschema/utilities.py

@@ -45,7 +45,7 @@ def load_json_source(source):
 
     try:
         return json.loads(source)
-    except ValueError as e:
+    except ValueError:
         raise exceptions.InvalidJSONError
 
 

jsontableschema/validate.py

@@ -97,7 +97,8 @@ def iter_errors(self, instance, _schema=None):
                             'be a string when foreignKey.reference.fields.'
                             'is a string'
                         )
-                    if not len(fk.get('fields')) == len(fk['reference']['fields']):
+                    if not (len(fk.get('fields')) ==
+                            len(fk['reference']['fields'])):
                         yield exceptions.SchemaValidationError(
                             'A JSON Table Schema foreignKey.fields must '
                             'contain the same number entries as '

pylama.ini

@@ -0,0 +1,11 @@
+[pylama]
+linters = pyflakes,mccabe,pep8
+
+[pylama:mccabe]
+complexity = 24
+
+[pylama:*/__init__.py]
+ignore = W0611
+
+[pylama:*/compat.py]
+ignore = W0611,E0602

pylintrc

@@ -0,0 +1,2 @@
+[pytest]
+testpaths = tests

pytest.ini

@@ -30,10 +30,8 @@ def read(*paths):
     'tabulator>=0.3',
     'unicodecsv>=0.14',
 ]
-LINT_REQUIRES = [
-    'pylint',
-]
 TESTS_REQUIRE = [
+    'pylama',
     'tox',
 ]
 README = read('README.md')
@@ -49,7 +47,7 @@ def read(*paths):
     include_package_data=True,
     install_requires=INSTALL_REQUIRES,
     tests_require=TESTS_REQUIRE,
-    extras_require={'develop': LINT_REQUIRES + TESTS_REQUIRE},
+    extras_require={'develop': TESTS_REQUIRE},
     entry_points={
         'console_scripts': [
             'jsontableschema = jsontableschema.cli:main',

setup.py

@@ -24,10 +24,3 @@ commands=
     --cov-config tox.ini \
     --cov-report term-missing \
     {posargs}
-
-[pytest]
-# pytest.ini configuration here
-testpaths = tests
-
-[report]
-# .coveragerc configuration here