Skip to content

Commit 69021a6

Browse files
committed
Fix missing comparison for equal versions
Signed-off-by: Leandro Lucarella <[email protected]>
1 parent 1b3c39c commit 69021a6

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

RELEASE_NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ But you might still need to adapt your code:
3131
## Bug Fixes
3232

3333
- Fixed some typos in the docs.
34+
- Fixed wrong comparison for `mike` versions when versions were equal.
3435

3536
### Cookiecutter template
3637

src/frequenz/repo/config/mkdocs/mike.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,9 @@ def compare_mike_version(version1: str, version2: str) -> int:
207207
if is_version_v2: # version1 is not a version
208208
return 1
209209

210+
if version1 == version2:
211+
return 0
212+
210213
return -1 if version1 < version2 else 1
211214

212215

tests/mkdocs/test_mike.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ def test_build_mike_version(
266266
("v2.0-pre", "v1.0-pre", 1),
267267
("v2.0", "v1.0-pre", 1),
268268
("blah", "v1.0-dev", 1),
269+
("blah", "blah", 0),
269270
("alpha", "beta", -1),
270271
],
271272
)

0 commit comments

Comments
 (0)