workflows: fix wikiupdate and bump version to v4 #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
reviewed
Feb 7, 2024
Noki
reviewed
Feb 7, 2024
Noki
requested changes
Feb 7, 2024
FFHener
force-pushed
the
testbuild-wikiupdater
branch
from
3d4f132 to
8f4c2ea
Compare
Noki
reviewed
Feb 8, 2024
FFHener
force-pushed
the
testbuild-wikiupdater
branch
from
8f4c2ea to
719dc50
Compare
…nger build images
Noki
force-pushed
the
testbuild-wikiupdater
branch
from
719dc50 to
69617b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the wikiupdate-workflow into a independent file making it way more clean. And it is working now as intended (instead of building all locations) as you can see here
with a changed location
without a changed location
I use
||trueso the task will never fail because there might be locations that doesn't get updated because they don't have a wikiarticle.In addition i bumped the version of
actions/checkout@v3to v4 as the old one was using Node.js 16 which is deprecated.