send-email: suppress meaningless whitespaces in from field

Remove leading and trailing whitespaces in from field before
interepreting it to improve consistency with other options.  The
split_addrs function already take care of trailing and leading
whitespaces for to, cc and bcc fields.
The from option now:

 - has the same behavior when passing arguments like
   "  [email protected] ", "\t [email protected] " or
   "[email protected]".

 - interprets aliases in string containing leading and trailing
   whitespaces such as " alias" or "alias\t" like other options.

Signed-off-by: Remi Lespinet <[email protected]>
Signed-off-by: Matthieu Moy <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>

Author: Awaryn

git-send-email.perl

@@ -761,6 +761,7 @@ sub file_declares_8bit_cte {
 }
 
 if (defined $sender) {
+	$sender =~ s/^\s+|\s+$//g;
 	($sender) = expand_aliases($sender);
 } else {
 	$sender = $repoauthor || $repocommitter || '';

t/t9001-send-email.sh

@@ -1692,4 +1692,28 @@ test_expect_success $PREREQ 'aliases work with email list' '
 	test_cmp expected-list actual-list
 '
 
+test_expect_success $PREREQ 'leading and trailing whitespaces are removed' '
+	echo "alias to2 [email protected]" >.mutt &&
+	echo "alias cc1 Cc 1 <[email protected]>" >>.mutt &&
+	test_config sendemail.aliasesfile ".mutt" &&
+	test_config sendemail.aliasfiletype mutt &&
+	TO1=$(echo "QTo 1 <[email protected]>" | q_to_tab) &&
+	TO2=$(echo "QZto2" | qz_to_tab_space) &&
+	CC1=$(echo "cc1" | append_cr) &&
+	BCC1=$(echo "Q [email protected] Q" | q_to_nul) &&
+	git send-email \
+	--dry-run \
+	--from="	Example <[email protected]>" \
+	--to="$TO1" \
+	--to="$TO2" \
+	--to="  [email protected]   " \
+	--cc="$CC1" \
+	--cc="Cc2 <[email protected]>" \
+	--bcc="$BCC1" \
+	--bcc="[email protected]" \
+	0001-add-master.patch | replace_variable_fields \
+	>actual-list &&
+	test_cmp expected-list actual-list
+'
+
 test_done