Skip to content

Commit eadf619

Browse files
devzero2000gitster
authored andcommitted
git-pull.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent faf58f4 commit eadf619

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-pull.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ do
108108
-s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy)
109109
case "$#,$1" in
110110
*,*=*)
111-
strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;;
111+
strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)') ;;
112112
1,*)
113113
usage ;;
114114
*)

0 commit comments

Comments
 (0)