Skip to content

Commit e429dfd

Browse files
devzero2000gitster
authored andcommitted
t/lib-httpd.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4796af1 commit e429dfd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/lib-httpd.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ then
9898
test_skip_or_die $GIT_TEST_HTTPD "no web server found at '$LIB_HTTPD_PATH'"
9999
fi
100100

101-
HTTPD_VERSION=`$LIB_HTTPD_PATH -v | \
102-
sed -n 's/^Server version: Apache\/\([0-9]*\)\..*$/\1/p; q'`
101+
HTTPD_VERSION=$($LIB_HTTPD_PATH -v | \
102+
sed -n 's/^Server version: Apache\/\([0-9]*\)\..*$/\1/p; q')
103103

104104
if test -n "$HTTPD_VERSION"
105105
then

0 commit comments

Comments
 (0)