Skip to content

Commit dcfafc5

Browse files
moygitster
authored andcommitted
Git.pm: add comment pointing to t9000
parse_mailboxes should probably eventually be completely equivalent to Mail::Address, and if this happens we can drop the Mail::Address dependency. Add a comment in the code reminding the current state of the code, and point to the corresponding failing test to help future contributors to get it right. Signed-off-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 8a420ed commit dcfafc5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

perl/Git.pm

+2
Original file line numberDiff line numberDiff line change
@@ -870,6 +870,8 @@ Return an array of mailboxes extracted from a string.
870870
871871
=cut
872872

873+
# Very close to Mail::Address's parser, but we still have minor
874+
# differences in some cases (see t9000 for examples).
873875
sub parse_mailboxes {
874876
my $re_comment = qr/\((?:[^)]*)\)/;
875877
my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;

0 commit comments

Comments
 (0)