Skip to content

Commit 92bea95

Browse files
devzero2000gitster
authored andcommitted
unimplemented.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 21c6f98 commit 92bea95

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

unimplemented.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#!/bin/sh
22

3-
echo >&2 "fatal: git was built without support for `basename $0` (@@REASON@@)."
3+
echo >&2 "fatal: git was built without support for $(basename $0) (@@REASON@@)."
44
exit 128

0 commit comments

Comments
 (0)