Does typings support work?

[ArturDorochowicz]

I was looking at typings support which, according to the readme, is supposed to get configured from systemjs package configuration like this:

packages: {
    "angular2": {
      "meta": {
        "*.js": {
          "typings": true     // can also be path of a typings bundle 
        }
      }
    }
  }

However I couldn't make it work and it made me look at the source code. Please correct me if I'm wrong, but as far as I understand the source code this package configuration is not used at all.

The typing lookup seems to be implemented in resolver.ts in Resolver.lookupTyping [1] which uses metadata returned from this._lookup. This is implemented in plugin.ts with _lookup [2].
This method always returns an empty metadata object and therefore lookupTyping always hits the "no typings" path.

What's up with this?

[1]

plugin-typescript/src/resolver.ts

Line 118 in b48702e

private lookupTyping(importName: string, sourceName: string, address: string): Promise<string> {

[2]

plugin-typescript/src/plugin.ts

Line 138 in b48702e

function _lookup(address: string): Promise<any> {

[frankwallis]

The call to System.locate in plugin.ts populates the empty metadata object with the correct data from the systemjs configuration.

Recent changes to systemjs mean that you may need to use the fully resolved package name to get this working, e.g.

 "npm:[email protected]": {
      "meta": {
        "*.js": {
          "typings": true
        }
      }
    },

This is working in the angular2 example contained in this repository.

[ArturDorochowicz]

Ok, sorry, I see it now. The api design got me confused.

NB I'd say it's a rather poor design on SystemJS part - modify the passed in argument and at the same time return a promise and not pass the result to the continuation.

Anyway, I still have a question about typings support. I actually was trying to get it working with Angular 1.4.6 installed with jspm and matching typings installed with typings tool. This means that the typings are in a completely different location than the package files. The readme says that instead of "typings": true I can use a string - i.e. the location of typings. So, my question is: is my scenario supported?

Feel free to close the issue. Thank you.

[frankwallis]

I think that you don't need any metadata configuration if you are using typings and angular1, you just need to make sure that typings/main.d.ts is included in the build. You can do this by adding it into the files array in tsconfig.json (or by adding a /// reference comment although that is no longer recommended.

See my comment here about the two different kinds of typings files. Metadata is only required for external typings.

[ArturDorochowicz]

@frankwallis Thanks for the explanation. Indeed, /// reference comment is what I use now and it works perfectly, but, considering that it is marked deprecated, I have been looking for a different option and the readme points to meta typings configuration.

I will experiment with tsconfig.json files configuration or other means of including the typings/main.d.ts in the build.

Thank you.