fix(errors): improve error reporting when files are missing

Author: frankwallis

lib/plugin.js

@@ -40,7 +40,10 @@ System.register(['typescript', './logger', './factory', './format-errors', './ut
                         .filter(utils_1.isTypescriptDeclaration)
                         .forEach(function (d) {
                         System.import(d + "!" + __moduleName)
-                            .catch(function (err) { throw err; });
+                            .catch(function (err) {
+                            logger.error(err);
+                            throw err;
+                        });
                     });
                     return load.source;
                 });

lib/type-checker.js

@@ -37,21 +37,9 @@ System.register(['typescript', './logger', './utils', "./compiler-host"], functi
                         return [];
                 };
                 TypeChecker.prototype.forceCheck = function () {
-                    var files = this._host.getAllFiles()
-                        .filter(function (file) { return file.fileName != compiler_host_1.__HTML_MODULE__; });
-                    var unchecked = files.filter(function (file) { return !file.checked; });
-                    var errored = files.filter(function (file) { return file.checked && utils_1.hasError(file.errors); });
-                    if ((errored.length > 0) || (unchecked.length > 0)) {
-                        return [{
-                                file: undefined,
-                                start: undefined,
-                                length: undefined,
-                                code: 9999,
-                                category: ts.DiagnosticCategory.Error,
-                                messageText: "compilation failed [" + files.length + " files, " + errored.length + " failed, " + unchecked.length + " unchecked]"
-                            }];
-                    }
-                    return [];
+                    var candidates = this.getCandidates();
+                    candidates.forEach(function (candidate) { return candidate.checkable = true; });
+                    return this.getAllDiagnostics(candidates);
                 };
                 TypeChecker.prototype.getCandidates = function () {
                     var _this = this;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "plugin-typescript",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "TypeScript loader for SystemJS",
   "main": "lib/plugin.js",
   "homepage": "https://github.com/frankwallis/plugin-typescript",

src/plugin.ts

@@ -63,7 +63,10 @@ export function translate(load: Module): Promise<string> {
                   .filter(isTypescriptDeclaration)
                   .forEach(d => {
                      System.import(d + "!" + __moduleName)
-                        .catch(err => { throw err });
+                        .catch(err => { 
+                           logger.error(err);
+                           throw err;
+                        });
                   });
 
                return load.source;

src/type-checker.ts

@@ -45,26 +45,12 @@ export class TypeChecker {
    }
 
 	/*
-		throws if there are compiler errors or unresolved files
+		type-checks any unchecked files even if all dependencies have not been loaded
 	*/
    public forceCheck(): ts.Diagnostic[] {
-      const files = this._host.getAllFiles()
-         .filter(file => file.fileName != __HTML_MODULE__);
-      const unchecked = files.filter(file => !file.checked);
-      const errored = files.filter(file => file.checked && hasError(file.errors));
-
-      if ((errored.length > 0) || (unchecked.length > 0)) {
-         return [{
-            file: undefined,
-            start: undefined,
-            length: undefined,
-            code: 9999,
-            category: ts.DiagnosticCategory.Error,
-            messageText: `compilation failed [${files.length} files, ${errored.length} failed, ${unchecked.length} unchecked]`
-         }];
-      }
-
-      return [];
+      const candidates = this.getCandidates();
+      candidates.forEach(candidate => candidate.checkable = true);
+      return this.getAllDiagnostics(candidates);
    }
 
    private getCandidates() {

test/resolver-spec.ts

@@ -197,5 +197,4 @@ describe('Resolver', () => {
       deps.list.should.have.length(1);
       deps.list[0].should.equal(expected);
    });
-
 });

test/type-checker-spec.ts

@@ -165,6 +165,34 @@ describe('TypeChecker', () => {
       diags.should.not.have.length(0);
    });
 
+   it('forceChecks files even if dependencies have not been loaded', async () => {
+      const options = {
+         noImplicitAny: true
+      };
+      host = new CompilerHost(options);
+      typeChecker = new TypeChecker(host);
+      resolver = new Resolver(host, resolve, lookup);
+      
+      const libName = (ts as any).normalizePath(require.resolve(host.getDefaultLibFileName()));
+      resolver.registerDeclarationFile(libName);
+      host.addFile(libName, fs.readFileSync(libName, 'utf8'));
+
+      // should pass normal check and fail forceCheck      
+      host.addFile("index.ts", '/// <reference path="declaration.d.ts" />\n import a from "amodule"; export = a;');
+      await resolver.resolve("index.ts")
+      let diags = typeChecker.check();
+      diags.should.have.length(0);      
+      diags = typeChecker.forceCheck();
+      diags.should.not.have.length(0);
+      
+      // now passes forceCheck
+      host.addFile("declaration.d.ts", "declare module 'amodule' { export var a: number; }");
+      await resolver.resolve("declaration.d.ts");
+      diags = typeChecker.forceCheck();
+      formatErrors(diags, console as any);
+      diags.should.have.length(0);            
+   });
+
    it('handles backslash in references', async () => {
       const diags = await typecheckAll(backslashReference);
       formatErrors(diags, console as any);