Merge pull request #9 from fpco/report-errors-on-stale

Report errors on stale cache

Author: anakinzhed

.github/workflows/test.yaml

@@ -26,7 +26,7 @@ jobs:
           tool: [email protected],[email protected]
       - uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: 1.81.0
+          toolchain: 1.89.0
           components: rustfmt, clippy
       - name: Compile
         run: just cargo-compile

rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.84.0"
+channel = "1.89.0"

src/lib.rs

@@ -419,11 +419,15 @@ impl<Loader: CacheLoader> AsyncLoader<Loader> {
             ValueForRender::Success { .. } => result,
             ValueForRender::Error {
                 stale_cache: Some(stale_cache),
-                ..
-            } => ValueForRender::Success {
-                value: stale_cache.value,
-                loaded: stale_cache.loaded,
-            },
+                message,
+                status,
+            } => {
+                tracing::error!("AsyncLoader::get_value_allow_stale: using stale cache, status=={status}, message: {message}");
+                ValueForRender::Success {
+                    value: stale_cache.value,
+                    loaded: stale_cache.loaded,
+                }
+            }
             ValueForRender::Error { .. } => result,
         }
     }